List:Commits« Previous MessageNext Message »
From:Stewart Smith Date:July 5 2007 12:28pm
Subject:Re: Please review---[Fwd: bk commit - 5.0 tree (gni:1.2473)
BUG#17788]
View as plain text  
On Thu, 2007-07-05 at 17:12 +0800, Guangbao Ni wrote:
>         +void Dblqh::execSTART_LCPIMME_CONF(Signal* signal)
>         +{
>         +  jamEntry();
>         +  lcpStartImmeResponded = true;
>         +  return;
>         +}

Should we reset lcpStartImmeResponded at end of LCP instead?

Otherwise (i think) we could keep sending START_LCPIMME_REQ while one is
already ongoing if we keep filling up the log?

Also, I think it should be reset on master failure so we send to new
master.

Perhaps when we send START_LCPIMME_REQ we should also create a cluster
log event that we forced an LCP start due to out of log.... that way
user can see from examining log if this is a frequent problem.
-- 
Stewart Smith, Senior Software Engineer
MySQL AB, www.mysql.com
Office: +14082136540 Ext: 6616
VoIP: 6616@stripped
Mobile: +61 4 3 8844 332

Jumpstart your cluster:
http://www.mysql.com/consulting/packaged/cluster.html

Attachment: [application/pgp-signature] This is a digitally signed message part signature.asc
Attachment: [application/pgp-signature] This is a digitally signed message part signature.asc
Thread
Re: Please review---[Fwd: bk commit - 5.0 tree (gni:1.2473)BUG#17788]Stewart Smith5 Jul
  • Re: Please review---[Fwd: bk commit - 5.0 tree (gni:1.2473) BUG#17788]Guangbao Ni6 Jul
Re: Please review---[Fwd: bk commit - 5.0 tree(gni:1.2473) BUG#17788]Stewart Smith6 Jul
  • Re: Please review---[Fwd: bk commit - 5.0 tree (gni:1.2473) BUG#17788]Guangbao Ni9 Jul