| List: | Commits | « Previous MessageNext Message » | |
| From: | Konstantin Osipov | Date: | July 4 2007 9:05pm |
| Subject: | Re: bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827 | ||
| View as plain text | |||
* Sergei Golubchik <serg@stripped> [07/07/03 17:30]: > > - if (bitmap_init(&part_info->full_part_field_set, NULL, > > + if (!(bitmap_buf= (my_bitmap_map*) > > + thd->alloc(bitmap_buffer_size(table->s->fields)))) > > + { > > + mem_alloc_error(bitmap_buffer_size(table->s->fields)); > > + result= TRUE; > > + goto end; > > + } > > + if (bitmap_init(&part_info->full_part_field_set, bitmap_buf, > > > > Do you agree with this change? This allocation scheme is already used > > elsewhere in the partition code. > Of course. Thanks for fixing it! JFYI, reporting mem_alloc_error is completely redundant, already done in thd->alloc. -- -- Konstantin Osipov Software Developer, Moscow, Russia -- MySQL AB, www.mysql.com The best DATABASE COMPANY in the GALAXY
| Thread | ||
|---|---|---|
| • bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827 | ingo | 27 Jun |
| • Re: bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827 | Sergei Golubchik | 3 Jul |
| • Re: bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827 | Ingo Strüwing | 3 Jul |
| • Re: bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827 | Sergei Golubchik | 3 Jul |
| • Re: bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827 | Ingo Strüwing | 3 Jul |
| • Re: bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827 | Ingo Strüwing | 3 Jul |
| • Re: bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827 | Sergei Golubchik | 3 Jul |
| • Re: bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827 | Konstantin Osipov | 4 Jul |
