Hi!
On Jul 03, Ingo Strüwing wrote:
>
> thanks for the review. Please see below for comments.
>
> Sergei Golubchik wrote:
> ...
> > Please try a test case with UPDATE IGNORE.
> > You will see that you cannot do rnd_pos() in the middle of a
> > table/index scan and then resume the scan.
>
> I tested it manually after I saw in the code that in case of IGNORE no
> error message is printed. My test verified that I got neither error
> messages nor warnings from UPDATE IGNORE. I might however have missed
> something. I'll try again and add a test to the patch.
Oops, sorry. I thought that in UPDATE IGNORE we issue a warning for
every conflict but continue the execution nevertheless.
Now I see that we don't even bother to issue a warning.
Okay, then there's no need to clone, and doing rnd_pos() in the same
handler is always correct.
Sorry for confusion.
Regards / Mit vielen Grüssen,
Sergei
--
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik <serg@stripped>
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Developer
/_/ /_/\_, /___/\___\_\___/ MySQL GmbH, Radlkoferstr. 2, D-81373 München
<___/ Geschäftsführer: Kaj Arnö - HRB
München 162140
