List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:July 3 2007 11:24am
Subject:Re: bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827
View as plain text  
Hi!

On Jun 27, ingo@stripped wrote:
> ChangeSet@stripped, 2007-06-27 20:26:52+02:00, istruewing@stripped +4 -0
>   Bug#26827 - table->read_set is set incorrectly,
>               causing update of a different column

ok to push

> --- 1.106/sql/sql_partition.cc	2007-06-27 20:27:05 +02:00
> +++ 1.107/sql/sql_partition.cc	2007-06-27 20:27:05 +02:00
> @@ -578,6 +578,28 @@ static bool create_full_part_field_array
>      part_info->full_part_field_array= field_array;
>      part_info->no_full_part_fields= no_part_fields;
>    }
> +
> +  /*
> +    Initialize the set of all fields used in partition and subpartition
> +    expression. Required for testing of partition fields in write_set
> +    when updating. We need to set all bits in read_set because the row
> +    may need to be inserted in a different [sub]partition.
> +  */
> +  if (bitmap_init(&part_info->full_part_field_set, NULL,
> +                  table->s->fields, FALSE))
> +  {
> +    mem_alloc_error(table->s->fields);

not terribly important, but
strictly speaking it should be bitmap_buffer_size(table->s->fields)

> +    result= TRUE;
> +    goto end;

Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Radlkoferstr. 2, D-81373 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140
Thread
bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827ingo27 Jun
  • Re: bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827Sergei Golubchik3 Jul
    • Re: bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827Ingo Strüwing3 Jul
      • Re: bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827Sergei Golubchik3 Jul
        • Re: bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827Ingo Strüwing3 Jul
          • Re: bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827Ingo Strüwing3 Jul
            • Re: bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827Sergei Golubchik3 Jul
        • Re: bk commit into 6.0-falcon tree (istruewing:1.2567) BUG#26827Konstantin Osipov4 Jul