List:Commits« Previous MessageNext Message »
From:cbell Date:July 2 2007 1:27pm
Subject:bk commit into 5.2 tree (cbell:1.2547)
View as plain text  
Below is the list of changes that have just been committed into a local
5.2 repository of cbell. When cbell does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-07-02 09:26:27-04:00, cbell@mysql_cab_desk. +1 -0
  WL#3570 : Default Backup
  
  This patch corrects a problem found in valgrind testing.

  sql/backup/be_default.cc@stripped, 2007-07-02 09:26:20-04:00, cbell@mysql_cab_desk. +1 -0
    WL#3570 : Default Backup
    
    This patch corrects a problem found in valgrind testing. The patch adds
    a call to the resest() method in the buffer_iterator class to free the
    memory allocated when writing a multiple block record during restore.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	cbell
# Host:	mysql_cab_desk.
# Root:	C:/source/c++/mysql-5.2-backup-test

--- 1.7/sql/backup/be_default.cc	2007-07-02 09:26:34 -04:00
+++ 1.8/sql/backup/be_default.cc	2007-07-02 09:26:34 -04:00
@@ -730,6 +730,7 @@
         rec_buffer.put_next((byte *)buf.data + META_SIZE, size);
         ptr= (byte *)rec_buffer.get_base_ptr();
         memcpy(cur_table->record[0], ptr, cur_table->s->reclength);
+        rec_buffer.reset();
         mode= CHECK_BLOBS;
       }
       default:

Thread
bk commit into 5.2 tree (cbell:1.2547)cbell2 Jul