List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:June 29 2007 6:24pm
Subject:Re: bk commit into 5.1 tree (gkodinov:1.2519) BUG#29157
View as plain text  
Hi!

On Jun 28, kgeorge@stripped wrote:
> ChangeSet@stripped, 2007-06-28 16:07:55+03:00, gkodinov@stripped +7 -0
>   Bug #29157: UPDATE, changed rows incorrect
>   
>   Sometimes the number of really updated rows (with changed
>   column values) cannot be determined at the server level
>   alone (e.g. if the storage engine does not return enough
>   column values to verify that). So the only dependable way
>   in such cases is to let the storage engine return that
>   information if possible.
>   Fixed the bug at server level by providing a way for the 
>   storage engine to return information about wether it 
>   actually updated the row or the old and the new column 
>   values are the same. It can do that by returning 
>   HA_ERR_RECORD_IS_THE_SAME in ha_update_row().
>   Note that each storage engine may choose not to try to
>   return this status code, so this behaviour remains 
>   storage engine specific.

Good.

ok to push

when you're done, please change the status of a bug from Documenting
to Verified, set category to InnoDB, and add a comment explaining why it
cannot be fixed on MySQL side and how it can be fixed in InnoDB.
I expect you will mostly refer to previous comments in the same
bugreport, instead of writing something new, still having everything
scattered throughout the bugreport isn't good enough, we need a
comment-conclusion at the very end, after "pushed into ..." comment.

Thank you.

Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Radlkoferstr. 2, D-81373 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140
Thread
bk commit into 5.1 tree (gkodinov:1.2519) BUG#29157kgeorge28 Jun
  • Re: bk commit into 5.1 tree (gkodinov:1.2519) BUG#29157Sergei Golubchik29 Jun
    • Re: bk commit into 5.1 tree (gkodinov:1.2519) BUG#29157Georgi Kodinov30 Jun
      • Re: bk commit into 5.1 tree (gkodinov:1.2519) BUG#29157Sergei Golubchik30 Jun
        • Re: bk commit into 5.1 tree (gkodinov:1.2519) BUG#29157Georgi Kodinov2 Jul