Hi Antony,
OK to push from me.
Please see some minor comments for the future (no need to change it this
time).
antony@stripped wrote:
...
> ChangeSet@stripped, 2007-06-28 00:23:14-07:00, antony@stripped +4 -0
> Bug#29019
> "REPLACE/INSERT IGNORE/UPDATE IGNORE doesn't work"
> Federated does not record neccessary HA_EXTRA flags in order to
> support REPLACE/INSERT IGNORE/UPDATE IGNORE.
> Implement ::extra() to capture flags neccessary for functionality.
> New function append_ident() to better escape identifiers consistantly.
...
> +/**
> + @brief Append identifiers to the string.
> +
> + @param[in,out] string The target string.
> + @param[in] name Identifier name
> + @param[in] length Length of identifier name in bytes
> + @param[in] quote_char Quote char to use for quoting identifier.
A new rule in the coding guildelines (at least I didn't notice it
before) says that parameter descriptions start with a lowercase letter
and do not end with a dot. Sorry. :-(
> +
> + @return Operation Status
> + @retval FALSE OK
> + @retval TRUE There was an error appending to the string.
Please indent retvals.
> +
> + @note This function is based upon the append_identifier() function
> + in sql_show.cc except that quoting always occurs.
> +*/
> +
> +static bool append_ident(String *string, const char *name, uint length,
> + const char quote_char)
...
> +/**
> + @brief Handles extra signals from MySQL server
> +
> + @param[in] operation Hint for storage engine
> +
> + @return Operation Status
> + @retval 0 OK
> + */
> +int ha_federated::extra(ha_extra_function operation)
Please have param description start with lower case letter, indent
retval, and have an empty line after the comment.
...
Regards
Ingo
--
Ingo Strüwing, Senior Software Developer
MySQL GmbH, Radlkoferstr. 2, D-81373 München
Geschäftsführer: Kaj Arnö - HRB München 162140
