bk commit into 5.1 tree (holyfoot:1.2554) BUG#28430

[holyfoot]

Below is the list of changes that have just been committed into a local
5.1 repository of hf. When hf does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-06-25 10:15:05+05:00, holyfoot@stripped +1 -0
  Bug #28430 Failiure in replication of innodb partitiitioned tables on row/mixed format.
  
  In the ha_partition::position() we didn't calculate the number
  of the partition of the record. We used m_last_part value
  instead, relying on that it is set in other place like
  previous call of ::write_row() or something.
  In replication, we do neither of these calls before ::position()
  Delete_rows_log_event::do_exec_row calls find_and_fetch_row
  there in the case of InnoDB partitions have HA_PRIMARY_KEY_REQUIRED_FOR_POSITION
  so use position() / rnd_pos() calls to fetch the record.
  Fixed by adding partition_id calculation to the ha_partition::position()

  sql/ha_partition.cc@stripped, 2007-06-25 10:15:02+05:00, holyfoot@stripped +2 -1
    Bug #28430 Failiure in replication of innodb partitiitioned tables on row/mixed
format.
    
    add HA_PRIMARY_KEY_REQUIRED_FOR_POSITION flag for the PARTITION handler

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	holyfoot
# Host:	hfmain.(none)
# Root:	/home/hf/work/28430/my51-28430

--- 1.93/sql/ha_partition.cc	2007-06-25 10:15:10 +05:00
+++ 1.94/sql/ha_partition.cc	2007-06-25 10:15:10 +05:00
@@ -383,7 +383,8 @@ bool ha_partition::initialise_partition(
     m_table_flags&= file->table_flags();
   } while (*(++file_array));
   m_table_flags&= ~(HA_CAN_GEOMETRY | HA_CAN_FULLTEXT | HA_DUPLICATE_POS |
-                    HA_CAN_SQL_HANDLER | HA_CAN_INSERT_DELAYED);
+                    HA_CAN_SQL_HANDLER | HA_CAN_INSERT_DELAYED |
+                    HA_PRIMARY_KEY_REQUIRED_FOR_POSITION);
   m_table_flags|= HA_FILE_BASED | HA_REC_NOT_IN_SEQ;
   DBUG_RETURN(0);
 }