List:Commits« Previous MessageNext Message »
From:Georgi Kodinov Date:June 22 2007 12:01pm
Subject:Re: bk commit into 5.0 tree (gkodinov:1.2494) BUG#27383
View as plain text  
Serg,

On 22.06.2007, at 14:03, Sergei Golubchik wrote:

> Hi!
>
> On Jun 22, kgeorge@stripped wrote:
>> ChangeSet@stripped, 2007-06-22 13:49:40+03:00, gkodinov@stripped  
>> +1 -0
>>   Bug #27383: Crash in test "mysql_client_test"
>
> Hm. Okay, I understand why you removed volatile from integer  
> variables.
> But are you sure it's safe to have float variable not volatile ?


The problem (as we determined over IRC) is in doublestore().  
floatstore() doesn't use such trickery, so IMHO it's safe to leave  
the existing code that uses the storage buffer to check for rounding  
errors (instead of the stack variable as we do for doubles to avoid  
the pointer aliasing effects introduced by doublestore()).

Best Regards,
Joro
-- 
Georgi Kodinov, Senior Software Engineer
MySQL AB, Plovdiv, Bulgaria, www.mysql.com
Office: +359 32 634 397 Mobile: +359 887 700 566 Skype: georgekodinov

Are you MySQL certified?  www.mysql.com/certification


Thread
bk commit into 5.0 tree (gkodinov:1.2494) BUG#27383kgeorge22 Jun
  • Re: bk commit into 5.0 tree (gkodinov:1.2494) BUG#27383Sergei Golubchik22 Jun
    • Re: bk commit into 5.0 tree (gkodinov:1.2494) BUG#27383Georgi Kodinov22 Jun