bk commit into 4.1 tree (ramil:1.2667) BUG#29079

[ramil]

Below is the list of changes that have just been committed into a local
4.1 repository of ram. When ram does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-06-22 17:12:40+05:00, ramil@stripped +1 -0
  Fix for bug #29079: Semantics of "bigint" depend on platform specifics (size, signedness
of char ?)
  
  Problem: long and long long types mess in a comparison may lead to wrong results on some
platforms.
  Fix: prefer [unsigned] long long as [u]longlong as it's used unconditionally in many
places.

  include/my_global.h@stripped, 2007-06-22 17:12:39+05:00, ramil@stripped +6 -1
    Fix for bug #29079: Semantics of "bigint" depend on platform specifics (size,
signedness of char ?)
      - use [unsigned] long long as [u]longlong if sizeof(long long) == 8, to avoid type
mess,
        as we use [unsigned] long long unconditionally in many places, for example in
constants 
        with [U]LL suffix.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	ramil
# Host:	ramil.myoffice.izhnet.ru
# Root:	/home/ram/work/b29079/b29079.4.1

--- 1.113/include/my_global.h	2007-06-22 17:12:43 +05:00
+++ 1.114/include/my_global.h	2007-06-22 17:12:43 +05:00
@@ -828,7 +828,12 @@ error "Neither int or long is of 4 bytes
 typedef unsigned long	ulong;		  /* Short for unsigned long */
 #endif
 #ifndef longlong_defined
-#if defined(HAVE_LONG_LONG) && SIZEOF_LONG != 8
+/* 
+  Using [unsigned] long long is preferable as [u]longlong because we use 
+  [unsigned] long long unconditionally in many places, 
+  for example in constants with [U]LL suffix.
+*/
+#if defined(HAVE_LONG_LONG) && SIZEOF_LONG_LONG == 8
 typedef unsigned long long int ulonglong; /* ulong or unsigned long long */
 typedef long long int	longlong;
 #else