Re: bk commit into 5.0 tree (gkodinov:1.2494) BUG#27383

[Sergei Golubchik]

Hi!

On Jun 22, kgeorge@stripped wrote:
> ChangeSet@stripped, 2007-06-22 13:49:40+03:00, gkodinov@stripped +1 -0
>   Bug #27383: Crash in test "mysql_client_test"

Hm. Okay, I understand why you removed volatile from integer variables.
But are you sure it's safe to have float variable not volatile ?
   
> --- 1.256/libmysql/libmysql.c	2007-05-24 21:51:35 +03:00
> +++ 1.257/libmysql/libmysql.c	2007-06-22 13:49:39 +03:00
> @@ -3681,15 +3681,18 @@ static void fetch_long_with_conversion(M
>    }
>    case MYSQL_TYPE_DOUBLE:
>    {
> -    double data;
> +    volatile double data;
>      if (is_unsigned)
> +    {
>        data= ulonglong2double(value);
> +      *param->error= ((ulonglong) value) != ((ulonglong) data);
> +    }
>      else
> +    {
>        data= (double)value;
> +      *param->error= value != ((longlong) data);
> +    }
>      doublestore(buffer, data);
> -    *param->error= is_unsigned ?
> -                   ((ulonglong) value) != ((ulonglong) (*(double*) buffer)) :
> -                   ((longlong) value) != ((longlong) (*(double*) buffer));
>      break;
>    }
>    case MYSQL_TYPE_TIME:
> 
Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Radlkoferstr. 2, D-81373 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140