From: Date: June 18 2007 4:03pm
Subject: bk commit into 5.1 tree (pekka:1.2496) BUG#29176
List-Archive: http://lists.mysql.com/commits/28998
X-Bug: 29176
Message-Id: <200706181403.l5IE3lDB019686@ndb13.mysql.com>

Below is the list of changes that have just been committed into a local
5.1 repository of pekka. When pekka does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-06-18 16:03:41+02:00, pekka@stripped +1 -0
  ndb - bug#29176 missing stack pruning in drop_page

  storage/ndb/src/kernel/blocks/pgman.cpp@stripped, 2007-06-18 16:02:23+02:00, pekka@stripped +18 -0
    missing stack pruning in drop_page

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	pekka
# Host:	ndb13.mysql.com
# Root:	/space/pekka/ndb/version/my51-bug29176

--- 1.25/storage/ndb/src/kernel/blocks/pgman.cpp	2007-06-18 16:03:47 +02:00
+++ 1.26/storage/ndb/src/kernel/blocks/pgman.cpp	2007-06-18 16:03:47 +02:00
@@ -1871,6 +1871,11 @@
 int
 Pgman::drop_page(Ptr<Page_entry> ptr)
 {
+#ifdef VM_TRACE
+  debugOut << "PGMAN: drop_page" << endl;
+  debugOut << "PGMAN: " << ptr << endl;
+#endif
+
   Page_stack& pl_stack = m_page_stack;
   Page_queue& pl_queue = m_page_queue;
 
@@ -1883,8 +1888,14 @@
     if (state & Page_entry::ONSTACK)
     {
       jam();
+      bool at_bottom = ! pl_stack.hasPrev(ptr);
       pl_stack.remove(ptr);
       state &= ~ Page_entry::ONSTACK;
+      if (at_bottom && (state & Page_entry::HOT))
+      {
+        jam();
+        lirs_stack_prune();
+      }
     }
 
     if (state & Page_entry::ONQUEUE)
@@ -2298,6 +2309,13 @@
   out << " lsn=" << dec << pe.m_lsn;
   out << " busy_count=" << dec << pe.m_busy_count;
 #ifdef VM_TRACE
+  {
+    Pgman::Page_stack& pl_stack = pe.m_this->m_page_stack;
+    if (! pl_stack.hasNext(ptr))
+      out << " top";
+    if (! pl_stack.hasPrev(ptr))
+      out << " bottom";
+  }
   {
     Pgman::Local_page_request_list 
       req_list(ptr.p->m_this->m_page_request_pool, ptr.p->m_requests);