bk commit into 5.1 tree (tomas:1.2488) BUG#20612

[tomas]

Below is the list of changes that have just been committed into a local
5.1 repository of tomas. When tomas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-06-03 19:30:37+02:00, tomas@stripped +1 -0
  Bug#20612.

  storage/ndb/src/kernel/blocks/pgman.cpp@stripped, 2007-06-03 19:30:35+02:00,
tomas@stripped +7 -0
    a) in one case pl_queue.remove(ptr) was not followed
    by state &= ~ Page_entry::ONQUEUE.
    
    b) when collecting initial hot entries have to remove
    from queue if somehow got there.
    
    b) is easy to get with large buffer cache (256M).
    a) or b) is probably cause of bug#20612.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	tomas
# Host:	whalegate.ndb.mysql.com
# Root:	/home/tomas/mysql-5.1-telco-gca

--- 1.23/storage/ndb/src/kernel/blocks/pgman.cpp	2007-05-28 12:20:32 +02:00
+++ 1.24/storage/ndb/src/kernel/blocks/pgman.cpp	2007-06-03 19:30:35 +02:00
@@ -669,6 +669,7 @@
         jam();
         move_cleanup_ptr(ptr);
         pl_queue.remove(ptr);
+        state &= ~ Page_entry::ONQUEUE;
       }
       if (state & Page_entry::BOUND)
       {
@@ -699,6 +700,12 @@
     pl_stack.add(ptr);
     state |= Page_entry::ONSTACK;
     state |= Page_entry::HOT;
+    // it could be on queue already
+    if (state & Page_entry::ONQUEUE) {
+      jam();
+      pl_queue.remove(ptr);
+      state &= ~Page_entry::ONQUEUE;
+    }
   }
 
   set_page_state(ptr, state);