Yes, please don't change the order. Our mysql 4->5 is a good bit more
painful because of column order changes (and case/name changes on
some, but the order hit us harder).
Thanks!
Chip
On 6/1/07, Mark Leith <mleith@stripped> wrote:
> Hi Stewart
>
> stewart@stripped wrote:
> > Add option to CHANGE MASTER TO MASTER_BIND
> > Add Master_Bind to SHOW SLAVE STATUS
> > Set OPT_BIND_ADDR for client connection in slave thread
> > default bind of all interfaces
> > ....
> > Index: telco-new/sql/slave.cc
> > ===================================================================
> > --- telco-new.orig/sql/slave.cc 2007-05-31 22:28:07.972811000 +1000
> > +++ telco-new/sql/slave.cc 2007-05-31 22:28:16.765360500 +1000
> > @@ -1210,6 +1210,8 @@ bool show_master_info(THD* thd, MASTER_I
> > sizeof(mi->user)));
> > field_list.push_back(new Item_return_int("Master_Port", 7,
> > MYSQL_TYPE_LONG));
> > + field_list.push_back(new Item_empty_string("Master_Bind",
> > + sizeof(mi->bind_addr)));
> > field_list.push_back(new Item_return_int("Connect_Retry", 10,
> > MYSQL_TYPE_LONG));
> >
>
> Slipping this in to the 'middle' of the list of already collected
> columns may break a number of scripts that are already out there in the
> world. Google specifically have already complained about us doing this
> kind of thing with SHOW SLAVE STATUS in the recent past (when we added
> columns, and changed letter cases)...
>
> I agree it 'looks' better where it is - but we need to ensure backwards
> compatibility for all other monitoring scripts out there as well - can
> you change this to add it to the bottom of the output please?
>
> Best regards
>
> Mark
>
> --
> Mark Leith, Senior Support Engineer
> MySQL AB, Worcester, England, www.mysql.com
> Are you MySQL certified? www.mysql.com/certification
>
>
> --
> MySQL Internals Mailing List
> For list archives: http://lists.mysql.com/internals
> To unsubscribe: http://lists.mysql.com/internals?unsub=1
>
>
--
Chip Turner cturner@stripped
