RE: bk commit into 5.1 tree (aelkin:1.2526) BUG#17654

[Chuck Bell]

Andrei,

Excellent catch on this one! Patch looks good. 

Chuck 

> -----Original Message-----
> From: Andrei Elkin [mailto:aelkin@stripped] 
> Sent: Wednesday, May 30, 2007 7:30 AM
> To: commits@stripped
> Subject: bk commit into 5.1 tree (aelkin:1.2526) BUG#17654
> 
> Below is the list of changes that have just been committed 
> into a local
> 5.1 repository of elkin. When elkin does a push these changes 
> will be propagated to the main repository and, within 24 
> hours after the push, to the public repository.
> For information on how to access the public repository see 
> http://dev.mysql.com/doc/mysql/en/installing-source-tree.html
> 
> ChangeSet@stripped, 2007-05-30 14:29:34+03:00, 
> aelkin@stripped +1 -0
>   bug#17654  --read-from-remote-server causes core
>   
>   fixing FD event issue that showed up on pb.
> 
>   client/mysqlbinlog.cc@stripped, 2007-05-30 14:29:31+03:00, 
> aelkin@stripped +1 -0
>     resetting temp_buf specially for FD event to avoid double-freeing
> 
> # This is a BitKeeper patch.  What follows are the unified 
> diffs for the # set of deltas contained in the patch.  The 
> rest of the patch, the part # that BitKeeper cares about, is 
> below these diffs.
> # User:	aelkin
> # Host:	dsl-hkibras1-ff5dc300-70.dhcp.inet.fi
> # Root:	/home/elkin/MySQL/TEAM/BARE/mysql-5.1-new-rpl
> 
> --- 1.156/client/mysqlbinlog.cc	2007-05-22 17:50:26 +03:00
> +++ 1.157/client/mysqlbinlog.cc	2007-05-30 14:29:31 +03:00
> @@ -635,6 +635,7 @@ Create_file event for file_id: %u\n",exv
>        print_event_info->common_header_len=
>          glob_description_event->common_header_len;
>        ev->print(result_file, print_event_info);
> +      ev->temp_buf= 0; // as the event ref is zeroed
>        /*
>          We don't want this event to be deleted now, so let's 
> hide it (I
>          (Guilhem) should later see if this triggers a 
> non-serious Valgrind
> 
> --
> MySQL Code Commits Mailing List
> For list archives: http://lists.mysql.com/commits
> To unsubscribe:    
> http://lists.mysql.com/commits?unsub=1
>