List:Commits« Previous MessageNext Message »
From:msvensson Date:May 21 2007 9:34am
Subject:bk commit into 5.0 tree (msvensson:1.2494) BUG#27438
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of msvensson. When msvensson does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-05-21 11:33:58+02:00, msvensson@stripped +2 -0
  Bug#27438  rpl_rotate_logs fails on Windows
   - Fix test case to work also when filesystem time differs
     from mysqld' time. I.e when running with data files on a
     network share.

  mysql-test/r/rpl_rotate_logs.result@stripped, 2007-05-21 11:33:57+02:00, msvensson@stripped +4 -1
    Update result file

  mysql-test/t/rpl_rotate_logs.test@stripped, 2007-05-21 11:33:57+02:00, msvensson@stripped +12 -3
    Calculate time to use in "purge master logs before" by taking
    last modification time of t2 and adding 1 second
    This is done in order to handle the case where file system time differs
    from mysqld's time

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	msvensson
# Host:	pilot.blaudden
# Root:	/home/msvensson/mysql/bug27438/my50-bug27438

--- 1.72/mysql-test/r/rpl_rotate_logs.result	2005-07-19 01:01:20 +02:00
+++ 1.73/mysql-test/r/rpl_rotate_logs.result	2007-05-21 11:33:57 +02:00
@@ -50,7 +50,10 @@ show binary logs;
 Log_name	File_size
 master-bin.000002	363
 master-bin.000003	407
-purge master logs before now();
+select @time_for_purge:=DATE_ADD(UPDATE_TIME, INTERVAL 1 SECOND)
+from information_schema.tables
+where TABLE_SCHEMA="test" and TABLE_NAME="t2";
+purge master logs before (@time_for_purge);
 show binary logs;
 Log_name	File_size
 master-bin.000003	407

--- 1.67/mysql-test/t/rpl_rotate_logs.test	2007-01-11 15:40:01 +01:00
+++ 1.68/mysql-test/t/rpl_rotate_logs.test	2007-05-21 11:33:57 +02:00
@@ -107,9 +107,18 @@ show master logs;
 # we just tests if synonyms are accepted
 purge binary logs to 'master-bin.000002';
 show binary logs;
-# sleeping 10 seconds or more would make the slave believe connection is down
---real_sleep 1
-purge master logs before now();
+
+# Calculate time to use in "purge master logs before" by taking
+# last modification time of t2 and adding 1 second
+# This is donw in order to handle the case where file system
+# time differs from mysqld's time
+--disable_result_log
+select @time_for_purge:=DATE_ADD(UPDATE_TIME, INTERVAL 1 SECOND)
+  from information_schema.tables
+    where TABLE_SCHEMA="test" and TABLE_NAME="t2";
+--enable_result_log
+
+purge master logs before (@time_for_purge);
 show binary logs;
 insert into t2 values (65);
 sync_slave_with_master;
Thread
bk commit into 5.0 tree (msvensson:1.2494) BUG#27438msvensson21 May