bk commit into 4.1 tree (jonas:1.2562) BUG#28443

[jonas]

Below is the list of changes that have just been committed into a local
4.1 repository of jonas. When jonas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-05-18 09:48:52+02:00, jonas@stripped +6 -0
  ndb - bug#28443
    Make sure that data can not e left lingering in receive buffer

  ndb/src/common/transporter/Packer.cpp@stripped, 2007-05-18 09:48:50+02:00,
jonas@stripped +5 -0
    test, make MAX_RECEIVED_SIGNALS an variable

  ndb/src/common/transporter/TCP_Transporter.hpp@stripped, 2007-05-18 09:48:51+02:00,
jonas@stripped +4 -0
    add new method for checking of data in receive buffer

  ndb/src/common/transporter/TransporterRegistry.cpp@stripped, 2007-05-18 09:48:51+02:00,
jonas@stripped +21 -18
    Make sure that 
    1) poll_TCP return true if any transporter has data in receiveBuffer
       (previously only if socket had data)
    2) performReceive executes signals if TCP transporter has data in receiveBuffer
       (previously only if data was recevied)

  ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp@stripped, 2007-05-18 09:48:51+02:00,
jonas@stripped +17 -0
    test, make MAX_RECEIVED_SIGNALS an variable

  ndb/test/ndbapi/testNdbApi.cpp@stripped, 2007-05-18 09:48:51+02:00,
jonas@stripped +34 -0
    testcase

  ndb/test/run-test/daily-basic-tests.txt@stripped, 2007-05-18 09:48:51+02:00,
jonas@stripped +4 -0
    testcase

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	jonas
# Host:	perch.ndb.mysql.com
# Root:	/home/jonas/src/41-work

--- 1.35/ndb/test/run-test/daily-basic-tests.txt	2007-05-18 09:48:54 +02:00
+++ 1.36/ndb/test/run-test/daily-basic-tests.txt	2007-05-18 09:48:54 +02:00
@@ -606,6 +606,10 @@
 cmd: testNdbApi
 args: -n Bug_11133 T1 
 
+max-time: 1000
+cmd: testNdbApi
+args: -n BugBug28443
+
 #max-time: 500
 #cmd: testInterpreter
 #args: T1 

--- 1.5/ndb/src/common/transporter/Packer.cpp	2007-05-18 09:48:54 +02:00
+++ 1.6/ndb/src/common/transporter/Packer.cpp	2007-05-18 09:48:54 +02:00
@@ -21,7 +21,12 @@
 #include <TransporterCallback.hpp>
 #include <RefConvert.hpp>
 
+#ifdef ERROR_INSERT
+Uint32 MAX_RECEIVED_SIGNALS = 1024;
+#else
 #define MAX_RECEIVED_SIGNALS 1024
+#endif
+
 Uint32
 TransporterRegistry::unpack(Uint32 * readPtr,
 			    Uint32 sizeOfData,

--- 1.4/ndb/src/common/transporter/TCP_Transporter.hpp	2007-05-18 09:48:54 +02:00
+++ 1.5/ndb/src/common/transporter/TCP_Transporter.hpp	2007-05-18 09:48:54 +02:00
@@ -100,6 +100,10 @@
   virtual void updateReceiveDataPtr(Uint32 bytesRead);
 
   virtual Uint32 get_free_buffer() const;
+
+  inline bool hasReceiveData () const {
+    return receiveBuffer.sizeOfData > 0;
+  }
 protected:
   /**
    * Setup client/server and perform connect/accept

--- 1.28/ndb/src/common/transporter/TransporterRegistry.cpp	2007-05-18 09:48:54 +02:00
+++ 1.29/ndb/src/common/transporter/TransporterRegistry.cpp	2007-05-18 09:48:54 +02:00
@@ -807,6 +807,7 @@
 Uint32 
 TransporterRegistry::poll_TCP(Uint32 timeOutMillis)
 {
+  bool hasdata = false;
   if (false && nTCPTransporters == 0)
   {
     tcpReadSelectReply = 0;
@@ -851,6 +852,7 @@
       // Put the connected transporters in the socket read-set 
       FD_SET(socket, &tcpReadset);
     }
+    hasdata |= t->hasReceiveData();
   }
   
   // The highest socket value plus one
@@ -867,7 +869,7 @@
   }
 #endif
   
-  return tcpReadSelectReply;
+  return tcpReadSelectReply || hasdata;
 }
 #endif
 
@@ -902,25 +904,26 @@
 #endif
 
 #ifdef NDB_TCP_TRANSPORTER
-  if(tcpReadSelectReply > 0)
+  for (int i=0; i<nTCPTransporters; i++) 
   {
-    for (int i=0; i<nTCPTransporters; i++) 
-    {
-      checkJobBuffer();
-      TCP_Transporter *t = theTCPTransporters[i];
-      const NodeId nodeId = t->getRemoteNodeId();
-      const NDB_SOCKET_TYPE socket    = t->getSocket();
-      if(is_connected(nodeId)){
-	if(t->isConnected() && FD_ISSET(socket, &tcpReadset)) 
+    checkJobBuffer();
+    TCP_Transporter *t = theTCPTransporters[i];
+    const NodeId nodeId = t->getRemoteNodeId();
+    const NDB_SOCKET_TYPE socket    = t->getSocket();
+    if(is_connected(nodeId)){
+      if(t->isConnected())
+      {
+        if (FD_ISSET(socket, &tcpReadset))
 	{
-	  const int receiveSize = t->doReceive();
-	  if(receiveSize > 0)
-	  {
-	    Uint32 * ptr;
-	    Uint32 sz = t->getReceiveData(&ptr);
-	    Uint32 szUsed = unpack(ptr, sz, nodeId, ioStates[nodeId]);
-	    t->updateReceiveDataPtr(szUsed);
-          }
+	  t->doReceive();
+        }
+
+        if (t->hasReceiveData())
+        {
+          Uint32 * ptr;
+          Uint32 sz = t->getReceiveData(&ptr);
+          Uint32 szUsed = unpack(ptr, sz, nodeId, ioStates[nodeId]);
+          t->updateReceiveDataPtr(szUsed);
 	}
       } 
     }

--- 1.23/ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp	2007-05-18 09:48:54 +02:00
+++ 1.24/ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp	2007-05-18 09:48:54 +02:00
@@ -135,6 +135,7 @@
 
 #ifdef ERROR_INSERT
 NodeBitmask c_error_9000_nodes_mask;
+extern Uint32 MAX_RECEIVED_SIGNALS;
 #endif
 
 void Cmvmi::execNDB_TAMPER(Signal* signal) 
@@ -162,6 +163,22 @@
   if(ERROR_INSERTED(9995)){
     simulate_error_during_shutdown= SIGSEGV;
     kill(getpid(), SIGABRT);
+  }
+#endif
+
+#ifdef ERROR_INSERT
+  if (signal->theData[0] == 9003)
+  {
+    if (MAX_RECEIVED_SIGNALS < 1024)
+    {
+      MAX_RECEIVED_SIGNALS = 1024;
+    }
+    else
+    {
+      MAX_RECEIVED_SIGNALS = rand() % 128;
+    }
+    ndbout_c("MAX_RECEIVED_SIGNALS: %d", MAX_RECEIVED_SIGNALS);
+    CLEAR_ERROR_INSERT_VALUE;
   }
 #endif
 }//execNDB_TAMPER()

--- 1.13/ndb/test/ndbapi/testNdbApi.cpp	2007-05-18 09:48:54 +02:00
+++ 1.14/ndb/test/ndbapi/testNdbApi.cpp	2007-05-18 09:48:54 +02:00
@@ -1131,7 +1131,36 @@
   return result;
 }
 
+int 
+runBug28443(NDBT_Context* ctx, NDBT_Step* step)
+{
+  int result = NDBT_OK;
+  int records = ctx->getNumRecords();
+  
+  NdbRestarter restarter;
 
+  restarter.insertErrorInAllNodes(9003);
+
+  for (Uint32 i = 0; i<ctx->getNumLoops(); i++)
+  {
+    HugoTransactions hugoTrans(*ctx->getTab());
+    if (hugoTrans.loadTable(GETNDB(step), records, 2048) != 0)
+    {
+      result = NDBT_FAILED;
+      goto done;
+    }
+    if (runClearTable(ctx, step) != 0)
+    {
+      result = NDBT_FAILED;
+      goto done;
+    }
+  }
+  
+done:
+  restarter.insertErrorInAllNodes(9003);
+
+  return result;
+}
 
 NDBT_TESTSUITE(testNdbApi);
 TESTCASE("MaxNdb", 
@@ -1210,6 +1239,11 @@
 TESTCASE("Bug_11133", 
 	 "Test ReadEx-Delete-Write\n"){ 
   INITIALIZER(runBug_11133);
+  FINALIZER(runClearTable);
+}
+TESTCASE("Bug28443", 
+	 ""){ 
+  INITIALIZER(runBug28443);
   FINALIZER(runClearTable);
 }
 NDBT_TESTSUITE_END(testNdbApi);