List:Commits« Previous MessageNext Message »
From:Sergey Vojtovich Date:May 17 2007 9:43am
Subject:bk commit into 4.1 tree (svoj:1.2651) BUG#25712
View as plain text  
Below is the list of changes that have just been committed into a local
4.1 repository of svoj. When svoj does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-05-17 12:43:52+05:00, svoj@stripped +1 -0
  Addition to fix for
  BUG#25712 - insert delayed and check table run together report
              crashed tables
  
  Let MY_THREADSAFE have distinct value. Some functions call my_seek
  passing MyFlags argument directly to it. This may cause unnecessary
  locks, which may finally lead to a dead-lock (specifically see my_lock).

  include/my_sys.h@stripped, 2007-05-17 12:43:51+05:00, svoj@stripped +1 -1
    Addition to fix for
    BUG#25712 - insert delayed and check table run together report
                crashed tables
    
    Let MY_THREADSAFE have distinct value. Some functions call my_seek
    passing MyFlags argument directly to it. This may cause unnecessary
    locks, which may finally lead to a dead-lock (specifically see my_lock).
    
    Also it doesn't affect my_pread/my_pwrite in any way. So the comment was
    updated.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	svoj
# Host:	june.mysql.com
# Root:	/home/svoj/devel/mysql/BUG25712/mysql-4.1-engines

--- 1.146/include/my_sys.h	2006-10-12 01:28:02 +05:00
+++ 1.147/include/my_sys.h	2007-05-17 12:43:51 +05:00
@@ -73,8 +73,8 @@ extern int NEAR my_errno;		/* Last error
 #define MY_ALLOW_ZERO_PTR 64	/* my_realloc() ; zero ptr -> malloc */
 #define MY_FREE_ON_ERROR 128	/* my_realloc() ; Free old ptr on error */
 #define MY_HOLD_ON_ERROR 256	/* my_realloc() ; Return old ptr on error */
-#define MY_THREADSAFE	128	/* pread/pwrite:  Don't allow interrupts */
 #define MY_DONT_OVERWRITE_FILE 1024	/* my_copy; Don't overwrite file */
+#define MY_THREADSAFE 2048      /* my_seek(): lock fd mutex */
 
 #define MY_CHECK_ERROR	1	/* Params to my_end; Check open-close */
 #define MY_GIVE_INFO	2	/* Give time info about process*/
Thread
bk commit into 4.1 tree (svoj:1.2651) BUG#25712Sergey Vojtovich17 May