bk commit into 5.1 tree (tomas:1.2503)

[tomas]

Below is the list of changes that have just been committed into a local
5.1 repository of tomas. When tomas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-05-07 21:52:23+02:00, tomas@stripped +5 -0
  make slave allow batching a variable
  change slave_allow_batching option yo slave-allow-batchine

  mysql-test/mysql-test-run.pl@stripped, 2007-05-07 21:52:19+02:00,
tomas@stripped +2 -2
    change slave_allow_batching option to slave-allow-batching

  sql/log_event.cc@stripped, 2007-05-07 21:52:19+02:00, tomas@stripped +4 -4
    make slave allow batching a variable

  sql/mysql_priv.h@stripped, 2007-05-07 21:52:19+02:00, tomas@stripped +1 -0
    make slave allow batching a variable

  sql/mysqld.cc@stripped, 2007-05-07 21:52:19+02:00, tomas@stripped +3 -4
    make slave allow batching a variable

  sql/set_var.cc@stripped, 2007-05-07 21:52:19+02:00, tomas@stripped +3 -0
    make slave allow batching a variable

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	tomas
# Host:	whalegate.ndb.mysql.com
# Root:	/home/tomas/mysql-5.1-telco-6.1-batch-slave

--- 1.265/sql/log_event.cc	2007-04-25 17:08:49 +02:00
+++ 1.266/sql/log_event.cc	2007-05-07 21:52:19 +02:00
@@ -31,8 +31,6 @@
 
 #define log_cs	&my_charset_latin1
 
-extern my_bool opt_slave_allow_batching;
-
 /*
   Cache that will automatically be written to a dedicated file on
   destruction.
@@ -5833,8 +5831,10 @@
     else
         thd->options&= ~OPTION_RELAXED_UNIQUE_CHECKS;
     
-    if (opt_slave_allow_batching)
-      thd->options |= OPTION_ALLOW_BATCH;
+    if (slave_allow_batching)
+      thd->options|= OPTION_ALLOW_BATCH;
+    else
+      thd->options&= ~OPTION_ALLOW_BATCH;
     
     /* A small test to verify that objects have consistent types */
     DBUG_ASSERT(sizeof(thd->options) == sizeof(OPTION_RELAXED_UNIQUE_CHECKS));

--- 1.471/sql/mysql_priv.h	2007-04-25 17:08:49 +02:00
+++ 1.472/sql/mysql_priv.h	2007-05-07 21:52:19 +02:00
@@ -1563,6 +1563,7 @@
 extern ulong slow_launch_threads, slow_launch_time;
 extern ulong table_cache_size, table_def_size;
 extern ulong max_connections,max_connect_errors, connect_timeout;
+extern my_bool slave_allow_batching;
 extern ulong slave_net_timeout, slave_trans_retries;
 extern uint max_user_connections;
 extern ulong what_to_log,flush_time;

--- 1.611/sql/mysqld.cc	2007-04-25 17:08:49 +02:00
+++ 1.612/sql/mysqld.cc	2007-05-07 21:52:19 +02:00
@@ -361,7 +361,6 @@
 my_bool opt_show_slave_auth_info, opt_sql_bin_update = 0;
 my_bool opt_log_slave_updates= 0;
 my_bool	opt_innodb;
-my_bool opt_slave_allow_batching= 0;
 
 /*
   Legacy global handlerton. These will be removed (please do not add more).
@@ -468,6 +467,7 @@
 ulong query_buff_size, slow_launch_time, slave_open_temp_tables;
 ulong open_files_limit, max_binlog_size, max_relay_log_size;
 ulong slave_net_timeout, slave_trans_retries;
+my_bool slave_allow_batching= 0;
 ulong thread_cache_size=0, binlog_cache_size=0, max_binlog_cache_size=0;
 ulong query_cache_size=0;
 ulong refresh_version, flush_version;	/* Increments on each reload */
@@ -6212,10 +6212,9 @@
    "before giving up and stopping.",
    (gptr*) &slave_trans_retries, (gptr*) &slave_trans_retries, 0,
    GET_ULONG, REQUIRED_ARG, 10L, 0L, (longlong) ULONG_MAX, 0, 1, 0},
-  {"slave_allow_batching", OPT_SLAVE_ALLOW_BATCHING,
+  {"slave-allow-batching", OPT_SLAVE_ALLOW_BATCHING,
    "Allow slave to batch requests.",
-   (gptr*) &opt_slave_allow_batching,
-   (gptr*) &opt_slave_allow_batching,
+   (gptr*) &slave_allow_batching, (gptr*) &slave_allow_batching,
    0, GET_BOOL, NO_ARG, 0, 0, 1, 0, 1, 0},
 #endif /* HAVE_REPLICATION */
   {"slow_launch_time", OPT_SLOW_LAUNCH_TIME,

--- 1.265/mysql-test/mysql-test-run.pl	2007-04-25 17:08:48 +02:00
+++ 1.266/mysql-test/mysql-test-run.pl	2007-05-07 21:52:19 +02:00
@@ -3650,7 +3650,7 @@
       mtr_add_arg($args, "%s--ndb-connectstring=%s", $prefix,
 		  $cluster->{'connect_string'});
       mtr_add_arg($args, "%s--ndb-wait-connected=20", $prefix);
-      mtr_add_arg($args, "%s--slave_allow_batching", $prefix);
+      mtr_add_arg($args, "%s--slave-allow-batching", $prefix);
       if ( $mysql_version_id >= 50100 )
       {
 	mtr_add_arg($args, "%s--ndb-extra-logging", $prefix);
@@ -3743,7 +3743,7 @@
       mtr_add_arg($args, "%s--ndb-connectstring=%s", $prefix,
 		  $clusters->[$slave->[$idx]->{'cluster'}]->{'connect_string'});
       mtr_add_arg($args, "%s--ndb-wait-connected=20", $prefix);
-      mtr_add_arg($args, "%s--slave_allow_batching", $prefix);
+      mtr_add_arg($args, "%s--slave-allow-batching", $prefix);
       if ( $mysql_version_id >= 50100 )
       {
 	mtr_add_arg($args, "%s--ndb-extra-logging", $prefix);

--- 1.211/sql/set_var.cc	2007-01-17 19:45:39 +01:00
+++ 1.212/sql/set_var.cc	2007-05-07 21:52:19 +02:00
@@ -418,6 +418,8 @@
 sys_var_bool_ptr	sys_slave_compressed_protocol("slave_compressed_protocol",
 						      &opt_slave_compressed_protocol);
 #ifdef HAVE_REPLICATION
+sys_var_bool_ptr        sys_slave_allow_batching("slave_allow_batching",
+                                                 &slave_allow_batching);
 sys_var_long_ptr	sys_slave_net_timeout("slave_net_timeout",
 					      &slave_net_timeout);
 sys_var_long_ptr	sys_slave_trans_retries("slave_transaction_retries",
@@ -971,6 +973,7 @@
   {"skip_networking",         (char*) &opt_disable_networking,      SHOW_BOOL},
   {"skip_show_database",      (char*) &opt_skip_show_db,            SHOW_BOOL},
 #ifdef HAVE_REPLICATION
+  {sys_slave_allow_batching.name,(char*) &sys_slave_allow_batching, SHOW_SYS},
   {sys_slave_compressed_protocol.name,
     (char*) &sys_slave_compressed_protocol,           SHOW_SYS},
   {"slave_load_tmpdir",       (char*) &slave_load_tmpdir,           SHOW_CHAR_PTR},