List:Commits« Previous MessageNext Message »
From:holyfoot Date:May 6 2007 8:40pm
Subject:bk commit into 5.1 tree (holyfoot:1.2513) BUG#28005
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of hf. When hf does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-05-06 23:40:16+05:00, holyfoot@stripped +3 -0
  Bug #28005 Partitions: can't use -9223372036854775808
  the Item_neg changes INT_RESULT with DECIMAL_RESULT when
  it gets this border value, what is not necessary.

  mysql-test/r/partition.result@stripped, 2007-05-06 23:40:13+05:00, holyfoot@stripped +2 -0
    result added

  mysql-test/t/partition.test@stripped, 2007-05-06 23:40:13+05:00, holyfoot@stripped +6 -0
    testcase

  sql/item_func.cc@stripped, 2007-05-06 23:40:14+05:00, holyfoot@stripped +1 -1
    we can handle '==' case in ordinary way - no need to use DECIMAL_RESULT

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	holyfoot
# Host:	hfmain.(none)
# Root:	/home/hf/work/28005/my51-28005

--- 1.381/sql/item_func.cc	2007-05-06 23:40:21 +05:00
+++ 1.382/sql/item_func.cc	2007-05-06 23:40:21 +05:00
@@ -1483,7 +1483,7 @@ void Item_func_neg::fix_length_and_dec()
   */
   if (hybrid_type == INT_RESULT &&
       args[0]->type() == INT_ITEM &&
-      ((ulonglong) args[0]->val_int() >= (ulonglong) LONGLONG_MIN))
+      ((ulonglong) args[0]->val_int() > (ulonglong) LONGLONG_MIN))
   {
     /*
       Ensure that result is converted to DECIMAL, as longlong can't hold

--- 1.62/mysql-test/r/partition.result	2007-05-06 23:40:21 +05:00
+++ 1.63/mysql-test/r/partition.result	2007-05-06 23:40:21 +05:00
@@ -1233,4 +1233,6 @@ select * from t1;
 c1	c2
 aaa	2
 drop table t1;
+create table t1 (s1 bigint) partition by list (s1) (partition p1 values in
(-9223372036854775808));
+drop table t1;
 End of 5.1 tests

--- 1.56/mysql-test/t/partition.test	2007-05-06 23:40:21 +05:00
+++ 1.57/mysql-test/t/partition.test	2007-05-06 23:40:21 +05:00
@@ -1441,5 +1441,11 @@ insert into t1 values ('aaa','1') on dup
 select * from t1;
 drop table t1;
 
+#
+# Bug #28005 Partitions: can't use -9223372036854775808 
+#
+
+create table t1 (s1 bigint) partition by list (s1) (partition p1 values in
(-9223372036854775808));
+drop table t1;
 
 --echo End of 5.1 tests
Thread
bk commit into 5.1 tree (holyfoot:1.2513) BUG#28005holyfoot6 May