bk commit into 5.0 tree (gkodinov:1.2442) BUG#27531

[kgeorge]

Below is the list of changes that have just been committed into a local
5.0 repository of kgeorge. When kgeorge does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-04-30 15:22:58+03:00, gkodinov@stripped +3 -0
  Bug #27531:
  When checking for applicability of join cache
  we must disable its usage only if there is no
  temp table in use.
  When a temp table is used we can use join
  cache (and it will not make the result-set 
  unordered) to fill the temp table. The filesort() 
  operation is then applied to the data in the temp 
  table and hence is not affected by join cache
  usage.
  Fixed by narrowing the condition for disabling 
  join cache to exclude the case where temp table
  is used.

  mysql-test/r/join.result@stripped, 2007-04-30 15:22:57+03:00, gkodinov@stripped +50 -0
    Bug #27531: test case

  mysql-test/t/join.test@stripped, 2007-04-30 15:22:57+03:00, gkodinov@stripped +23 -0
    Bug #27531: test case

  sql/sql_select.cc@stripped, 2007-04-30 15:22:57+03:00, gkodinov@stripped +6 -3
    Bug #27531: 
    Disable join cache only if not using temp table

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	gkodinov
# Host:	magare.gmz
# Root:	/home/kgeorge/mysql/work/B27531-5.0-opt

--- 1.511/sql/sql_select.cc	2007-04-21 19:27:34 +03:00
+++ 1.512/sql/sql_select.cc	2007-04-30 15:22:57 +03:00
@@ -5980,11 +5980,14 @@ make_join_readinfo(JOIN *join, ulonglong
       disable join cache because it will change the ordering of the results.
       Code handles sort table that is at any location (not only first after 
       the const tables) despite the fact that it's currently prohibited.
+      We must disable join cache if the first non-const table alone is
+      ordered. If there is a temp table the ordering is done as a last
+      operation and doesn't prevent join cache usage.
     */
-    if (!ordered_set && 
-        (table == join->sort_by_table &&
+    if (!ordered_set && !join->need_tmp &&
+        ((table == join->sort_by_table &&
          (!join->order || join->skip_sort_order)) ||
-        (join->sort_by_table == (TABLE *) 1 && i != join->const_tables))
+        (join->sort_by_table == (TABLE *) 1 && i != join->const_tables)))
       ordered_set= 1;
 
     switch (tab->type) {

--- 1.42/mysql-test/r/join.result	2007-04-19 02:04:20 +03:00
+++ 1.43/mysql-test/r/join.result	2007-04-30 15:22:57 +03:00
@@ -807,4 +807,54 @@ Handler_read_prev	0
 Handler_read_rnd	0
 Handler_read_rnd_next	5
 drop table t1, t2, t3;
+CREATE TABLE t1 (a int, b int default 0, c int default 1);
+INSERT INTO t1 (a) VALUES (1),(2),(3),(4),(5),(6),(7),(8);
+INSERT INTO t1 (a) SELECT a + 8 FROM t1;
+INSERT INTO t1 (a) SELECT a + 16 FROM t1;
+CREATE TABLE t2 (a int, d int, e int default 0);
+INSERT INTO t2 (a, d) VALUES (1,1),(2,2),(3,3),(4,4);
+INSERT INTO t2 (a, d) SELECT a+4, a+4 FROM t2;
+INSERT INTO t2 (a, d) SELECT a+8, a+8 FROM t2;
+EXPLAIN
+SELECT STRAIGHT_JOIN t2.e FROM t1,t2 WHERE t2.d=1 AND t1.b=t2.e
+ORDER BY t1.b, t1.c;
+id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra
+1	SIMPLE	t1	ALL	NULL	NULL	NULL	NULL	32	Using temporary; Using filesort
+1	SIMPLE	t2	ALL	NULL	NULL	NULL	NULL	16	Using where
+SELECT STRAIGHT_JOIN t2.e FROM t1,t2 WHERE t2.d=1 AND t1.b=t2.e
+ORDER BY t1.b, t1.c;
+e
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+0
+DROP TABLE t1,t2;
 End of 5.0 tests.

--- 1.36/mysql-test/t/join.test	2007-04-19 02:04:20 +03:00
+++ 1.37/mysql-test/t/join.test	2007-04-30 15:22:57 +03:00
@@ -632,5 +632,28 @@ explain select * from t1, t2, t3 where t
 show status like 'Handler_read%'; 
 drop table t1, t2, t3;
 
+#
+# Bug #27531: Query performance degredation in 4.1.22 and greater
+#
+CREATE TABLE t1 (a int, b int default 0, c int default 1);
+
+INSERT INTO t1 (a) VALUES (1),(2),(3),(4),(5),(6),(7),(8);
+INSERT INTO t1 (a) SELECT a + 8 FROM t1;
+INSERT INTO t1 (a) SELECT a + 16 FROM t1;
+
+CREATE TABLE t2 (a int, d int, e int default 0);
+
+INSERT INTO t2 (a, d) VALUES (1,1),(2,2),(3,3),(4,4);
+INSERT INTO t2 (a, d) SELECT a+4, a+4 FROM t2;
+INSERT INTO t2 (a, d) SELECT a+8, a+8 FROM t2;
+
+# should use join cache
+EXPLAIN
+SELECT STRAIGHT_JOIN t2.e FROM t1,t2 WHERE t2.d=1 AND t1.b=t2.e
+  ORDER BY t1.b, t1.c;
+SELECT STRAIGHT_JOIN t2.e FROM t1,t2 WHERE t2.d=1 AND t1.b=t2.e
+  ORDER BY t1.b, t1.c;
+
+DROP TABLE t1,t2;
 
 --echo End of 5.0 tests.