List:Commits« Previous MessageNext Message »
From:justin.he Date:April 25 2007 6:59am
Subject:bk commit into 5.1 tree (Justin.He:1.2553) BUG#24560
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of justin.he. When justin.he does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-04-25 12:59:27+08:00, Justin.He@stripped +1 -0
  Bug#24560 Data nodes died(lgman) if undo_buffer_size from logfile group has small value

  storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp@stripped, 2007-04-25 12:59:24+08:00,
Justin.He@stripped +5 -1
    since undo_buffer_size cannot be less than 96KB in LGMAN block,
    add a check to verify this limitation

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	Justin.He
# Host:	dev3-240.dev.cn.tlan
# Root:	/home/justin.he/mysql/mysql-5.1/bug24560-5.1-new-ndb-bj

--- 1.122/storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp	2007-04-25 12:59:35 +08:00
+++ 1.123/storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp	2007-04-25 12:59:35 +08:00
@@ -18,6 +18,7 @@
 
 #define DBDICT_C
 #include "Dbdict.hpp"
+#include "diskpage.hpp"
 
 #include <ndb_limits.h>
 #include <NdbOut.hpp>
@@ -15547,7 +15548,10 @@
     } 
     else if(fg.FilegroupType == DictTabInfo::LogfileGroup)
     {
-      if(!fg.LF_UndoBufferSize)
+      /**
+       * undo_buffer_size can't be less than 96KB in LGMAN block 
+       */
+      if(fg.LF_UndoBufferSize < 3 * File_formats::NDB_PAGE_SIZE)
       {
 	op->m_errorCode = CreateFilegroupRef::InvalidUndoBufferSize;
 	break;
Thread
bk commit into 5.1 tree (Justin.He:1.2553) BUG#24560justin.he25 Apr