bk commit into 5.1 tree (mleich:1.2571) BUG#18946

[mleich]

Below is the list of changes that have just been committed into a local
5.1 repository of mleich. When mleich does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-04-24 19:05:19+02:00, mleich@stripped +1 -0
  The fix for   Bug#18946: Test case rpl_ndb_ddl disabled   pushed around end of March 2007 enabled this testcase.
  It was later disabled because the test failed with timeout on one testing box.
  The reason for this failing test could not be found because we do not have informations about the conditions on the box during this test.
  Jeb and I tried this test on other boxes and it passed.
  My experience is that
  - tests using NDB need in general often significant more runtime
    than comparable tests of other storage engines
  - the actual load of the box where the test is running and the
    filesystem (nfs could be extreme slow) where the tests are
    executed might have a huge impact on the test performance 
    (runtime * 2 till 3)
  - there are sometimes problems with the ports most probably
    caused by OS properties (NDB+RPL need many ports) or
    parallel tests accidently running with the same ports.
  AFAIK these are the reasons why the NDB tests fail sometimes with timeout.
  Conclusion: We enable rpl_ndb_ddl again because the failure happens in rare cases
  and seems not to be caused by errors within the server or test code. 

  mysql-test/t/disabled.def@stripped, 2007-04-24 19:05:17+02:00, mleich@stripped +0 -1
    Enable t/rpl_ndb_ddl.test again

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	mleich
# Host:	four.local.lan
# Root:	/WORK/mysql-5.1-rpl/src-clean

--- 1.247/mysql-test/t/disabled.def	2007-04-24 19:05:24 +02:00
+++ 1.248/mysql-test/t/disabled.def	2007-04-24 19:05:24 +02:00
@@ -23,7 +23,6 @@ rpl_ndb_circular_simplex : BUG#27972 200
 rpl_ndb_2innodb          : BUG#19227 2006-04-20 pekka pk delete apparently not replicated
 rpl_ndb_2myisam          : BUG#19227 Seems to pass currently
 rpl_ndb_dd_partitions    : BUG#19259 2006-04-21 rpl_ndb_dd_partitions fails on s/AMD
-rpl_ndb_ddl              : BUG#18946 result file needs update + test needs to checked
 rpl_ddl                  : BUG#26418 2007-03-01 mleich Slave out of sync after CREATE/DROP TEMPORARY TABLE + ROLLBACK on master
 rpl_ndb_innodb2ndb       : Bug #19710  Cluster replication to partition table fails on DELETE FROM statement
 rpl_ndb_myisam2ndb       : Bug #19710  Cluster replication to partition table fails on DELETE FROM statement