bk commit into 5.0 tree (msvensson:1.2464)

[msvensson]

Below is the list of changes that have just been committed into a local
5.0 repository of msvensson. When msvensson does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-04-19 17:00:29+02:00, msvensson@stripped +3 -0
  mysql_upgrade win fixes

  client/mysql_upgrade.c@stripped, 2007-04-19 17:00:27+02:00, msvensson@stripped +8 -5
    Windows fix

  scripts/CMakeLists.txt@stripped, 2007-04-19 17:00:27+02:00, msvensson@stripped +6 -3
    Fix problems with CMakeList causing build to fail

  scripts/comp_sql.c@stripped, 2007-04-19 17:00:27+02:00, msvensson@stripped +2 -2
    Improve comp_sql.c to generate output file with shorter strings

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	msvensson
# Host:	pilot.blaudden
# Root:	/home/msvensson/mysql/mysql-5.0-maint

--- 1.22/client/mysql_upgrade.c	2007-04-18 19:00:41 +02:00
+++ 1.23/client/mysql_upgrade.c	2007-04-19 17:00:27 +02:00
@@ -335,6 +335,10 @@ static int run_tool(char *tool_path, DYN
 
   va_end(args);
 
+#ifdef __WIN__
+  dynstr_append(&ds_cmdline, "\"");
+#endif
+
   DBUG_PRINT("info", ("Running: %s", ds_cmdline.str));
   ret= run_command(ds_cmdline.str, ds_res);
   DBUG_PRINT("exit", ("ret: %d", ret));
@@ -354,11 +358,11 @@ static my_bool get_full_path_to_executab
 {
   my_bool ret;
   DBUG_ENTER("get_full_path_to_executable");
-#ifdef WIN
-  ret= GetModuleFileName(NULL, path, FN_REFLEN) != 0;
+#ifdef __WIN__
+  ret= (GetModuleFileName(NULL, path, FN_REFLEN) == 0);
 #else
   /* my_readlink returns 0 if a symlink was read */
-  ret= my_readlink(path, "/proc/self/exe", MYF(0)) != 0;
+  ret= (my_readlink(path, "/proc/self/exe", MYF(0)) != 0);
   /* Might also want to try with /proc/$$/exe if the above fails */
 #endif
   DBUG_PRINT("exit", ("path: %s", path));
@@ -416,8 +420,7 @@ static void find_tool(char *tool_path, c
     DBUG_PRINT("enter", ("path: %s", path));
 
     /* Chop off last char(since it might be a /) */
-    size_t pos= max((strlen(path)-1), 0);
-    path[pos]= 0;
+    path[max((strlen(path)-1), 0)]= 0;
 
     /* Chop off last dir part */
     dirname_part(path, path);

--- 1.1/scripts/CMakeLists.txt	2007-04-18 13:21:38 +02:00
+++ 1.2/scripts/CMakeLists.txt	2007-04-19 17:00:27 +02:00
@@ -20,9 +20,12 @@ TARGET_LINK_LIBRARIES(comp_sql dbug mysy
 # Build comp_sql - used for embedding SQL in C or C++ programs
 GET_TARGET_PROPERTY(COMP_SQL_EXE comp_sql LOCATION)
 
-ADD_CUSTOM_COMMAND(OUTPUT ${PROJECT_SOURCE_DIR}/client/mysql_fix_privilege_tables_sql.c
+ADD_CUSTOM_COMMAND(OUTPUT ${PROJECT_SOURCE_DIR}/scripts/mysql_fix_privilege_tables_sql.c
                    COMMAND ${COMP_SQL_EXE}
-		   ${PROJECT_SOURCE_DIR}/scripts/mysql_fix_privilege_tables.sql
-		   ${PROJECT_SOURCE_DIR}/client/mysql_fix_privilege_tables_sql.c
+                   mysql_fix_privilege_tables.sql
+		           mysql_fix_privilege_tables_sql.c
                    DEPENDS comp_sql ${PROJECT_SOURCE_DIR}/scripts/mysql_fix_privilege_tables.sql)
 
+ADD_CUSTOM_TARGET(GenFixPrivs
+                  ALL
+                  DEPENDS ${PROJECT_SOURCE_DIR}/scripts/mysql_fix_privilege_tables_sql.c)

--- 1.1/scripts/comp_sql.c	2007-04-18 13:21:38 +02:00
+++ 1.2/scripts/comp_sql.c	2007-04-19 17:00:27 +02:00
@@ -74,7 +74,7 @@ int main(int argc, char *argv[])
   while(*end && *end != '.')
     end++;
   *end= 0;
-  fprintf(out, "const char* %s={\"\\\n", infile_name);
+  fprintf(out, "const char* %s={\n\"", infile_name);
 
   while (fgets(buff, sizeof(buff), in))
   {
@@ -87,7 +87,7 @@ int main(int argc, char *argv[])
           Reached end of line, add escaped newline, escaped
           backslash and a newline to outfile
         */
-        fprintf(out, "\\n\\\n");
+        fprintf(out, "\\n \"\n\"");
         curr++;
       }
       else if (*curr == '\r')