List:Commits« Previous MessageNext Message »
From:Mats Kindahl Date:March 30 2007 1:25pm
Subject:bk commit into 5.1 tree (mats:1.2539)
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of mats. When mats does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-03-30 15:25:33+02:00, mats@romeo.(none) +4 -0
  WL#3464 (Add replication event to denote gap in replication):
  Fixing automerge problem and updating comments referring to exec_event().

  sql/log_event.cc@stripped, 2007-03-30 15:25:28+02:00, mats@romeo.(none) +2 -2
    Renaming exec_event() to do_apply_event().

  sql/log_event.h@stripped, 2007-03-30 15:25:28+02:00, mats@romeo.(none) +1 -1
    Renaming exec_event() to do_apply_event().

  sql/rpl_rli.cc@stripped, 2007-03-30 15:25:29+02:00, mats@romeo.(none) +3 -3
    Fixing comments referring to exec_event(), which does not exist any more.

  sql/sql_class.h@stripped, 2007-03-30 15:25:29+02:00, mats@romeo.(none) +1 -1
    Fixing comments referring to exec_event(), which does not exist any more.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	mats
# Host:	romeo.(none)
# Root:	/home/bk/w3464-mysql-5.1-new-rpl

--- 1.274/sql/log_event.cc	2007-03-30 15:25:42 +02:00
+++ 1.275/sql/log_event.cc	2007-03-30 15:25:42 +02:00
@@ -7956,9 +7956,9 @@
 
 #if defined(HAVE_REPLICATION) && !defined(MYSQL_CLIENT)
 int
-Incident_log_event::exec_event(st_relay_log_info *rli)
+Incident_log_event::do_apply_event(RELAY_LOG_INFO const *rli)
 {
-  DBUG_ENTER("Incident_log_event::exec_event");
+  DBUG_ENTER("Incident_log_event::do_apply_event");
   slave_print_msg(ERROR_LEVEL, rli, ER_SLAVE_INCIDENT,
                   ER(ER_SLAVE_INCIDENT),
                   description(),

--- 1.144/sql/log_event.h	2007-03-30 15:25:42 +02:00
+++ 1.145/sql/log_event.h	2007-03-30 15:25:42 +02:00
@@ -2588,7 +2588,7 @@
 #endif
 
 #if !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION)
-  virtual int exec_event(struct st_relay_log_info *rli);
+  virtual int do_apply_event(RELAY_LOG_INFO const *rli);
 #endif
 
   virtual bool write_data_header(IO_CACHE *file);

--- 1.349/sql/sql_class.h	2007-03-30 15:25:42 +02:00
+++ 1.350/sql/sql_class.h	2007-03-30 15:25:42 +02:00
@@ -1270,7 +1270,7 @@
     return first_successful_insert_id_in_prev_stmt;
   }
   /*
-    Used by Intvar_log_event::exec_event() and by "SET INSERT_ID=#"
+    Used by Intvar_log_event::do_apply_event() and by "SET INSERT_ID=#"
     (mysqlbinlog). We'll soon add a variant which can take many intervals in
     argument.
   */

--- 1.6/sql/rpl_rli.cc	2007-03-30 15:25:42 +02:00
+++ 1.7/sql/rpl_rli.cc	2007-03-30 15:25:42 +02:00
@@ -969,7 +969,7 @@
      strtol() conversions needed for log names comparison. We don't need to
      compare them each time this function is called, we only need to do this
      when current log name changes. If we have UNTIL_MASTER_POS condition we
-     need to do this only after Rotate_log_event::exec_event() (which is
+     need to do this only after Rotate_log_event::do_apply_event() (which is
      rare, so caching gives real benifit), and if we have UNTIL_RELAY_POS
      condition then we should invalidate cached comarison value after
      inc_group_relay_log_pos() which called for each group of events (so we
@@ -1093,12 +1093,12 @@
 
   DBUG_ASSERT(sql_thd == thd);
   /*
-    1) Instances of Table_map_log_event, if ::exec_event() was called on them,
+    1) Instances of Table_map_log_event, if ::do_apply_event() was called on them,
     may have opened tables, which we cannot be sure have been closed (because
     maybe the Rows_log_event have not been found or will not be, because slave
     SQL thread is stopping, or relay log has a missing tail etc). So we close
     all thread's tables. And so the table mappings have to be cancelled.
-    2) Rows_log_event::exec_event() may even have started statements or
+    2) Rows_log_event::do_apply_event() may even have started statements or
     transactions on them, which we need to rollback in case of error.
     3) If finding a Format_description_log_event after a BEGIN, we also need
     to rollback before continuing with the next events.
Thread
bk commit into 5.1 tree (mats:1.2539)Mats Kindahl31 Mar