From: Date: February 8 2006 10:13pm
Subject: bk commit into 5.1 tree (tomas:1.2093) BUG#17206
List-Archive: http://lists.mysql.com/commits/2335
X-Bug: 17206
Message-Id: <20060208211359.D509B817AC@poseidon.mysql.com>

Below is the list of changes that have just been committed into a local
5.1 repository of tomas. When tomas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2093 06/02/08 22:13:47 tomas@stripped +1 -0
  Bug #17206      Update through VIEW is not working
  post review fixes
  Bug fix added missing setting of rw_set for table handler when update occurs via a view.   The missing setting of the rw_set resulted in fields not being updated for ndb tables

  sql/sql_base.cc
    1.300 06/02/08 22:13:40 tomas@stripped +8 -2
    Bug #17206      Update through VIEW is not working
    post review fixes
    Bug fix added missing setting of rw_set for table handler when update occurs via a view.   The missing setting of the rw_set resulted in fields not being updated for ndb tables

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	tomas
# Host:	poseidon.ndb.mysql.com
# Root:	/home/tomas/mysql-5.1-new

--- 1.299/sql/sql_base.cc	2006-02-08 18:08:09 +01:00
+++ 1.300/sql/sql_base.cc	2006-02-08 22:13:40 +01:00
@@ -3869,6 +3869,11 @@
 #endif
       if (thd->set_query_id)
       {
+        /*
+         * get rw_set correct for this field so that the handler
+         * knows that this field is involved in the query and gets
+         * retrieved/updated
+         */
         Field *field_to_set= NULL;
         if (fld == view_ref_found)
         {
@@ -3879,8 +3884,9 @@
         else
           field_to_set= fld;
         if (field_to_set)
-          field_to_set->table->file->ha_set_bit_in_rw_set(field_to_set->fieldnr,
-                                                          (bool)(thd->set_query_id-1));
+          field_to_set->table->file->
+            ha_set_bit_in_rw_set(field_to_set->fieldnr,
+                                 (bool)(thd->set_query_id-1));
       }
   }
   DBUG_RETURN(fld);