From: Date: February 8 2006 11:05am
Subject: bk commit into 5.1 tree (reggie:1.2087) BUG#17082
List-Archive: http://lists.mysql.com/commits/2322
X-Bug: 17082
Message-Id: <20060208100500.871792C9C1@linux.site>

Below is the list of changes that have just been committed into a local
5.1 repository of reggie. When reggie does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2087 06/02/08 04:04:49 reggie@stripped +1 -0
  bug# 17082 Client hangs when creating tables with partition
  This bug was only on Windows but we updated the call to 
  create_temporary_file to match what is being done in other
  areas of MySQL

  sql/sql_partition.cc
    1.32 06/02/08 04:04:40 reggie@stripped +3 -2
    the O_RDWR mode and MY_WME were used in this code before the switch
    was made to create_temp_file.  The parameters are still there
    so we just plug in the mode and WME so the underlying code will 
    create the temp file with the right mode.  This only affected 
    Windows.  [This comment was from the first changset that I was unable
    to bk fix].  This changeset adds O_BINARY | O_TRUNC | O_TEMPORARY

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	reggie
# Host:	linux.site
# Root:	/home/reggie/work/mysql-5.1

--- 1.31/sql/sql_partition.cc	2006-02-07 05:11:30 -06:00
+++ 1.32/sql/sql_partition.cc	2006-02-08 04:04:40 -06:00
@@ -2397,8 +2397,9 @@
   DBUG_ENTER("generate_partition_syntax");
 
   write_part_state= (part_info->part_state && !part_info->part_state_len);
-  if (unlikely(((fptr= create_temp_file(path,mysql_tmpdir,"psy", O_RDWR, 
-                                        MYF(MY_WME)))) < 0))
+  if (unlikely(((fptr= create_temp_file(path,mysql_tmpdir,"psy", 
+                                        O_RDWR | O_BINARY | O_TRUNC |  
+                                        O_TEMPORARY, MYF(MY_WME)))) < 0))
     DBUG_RETURN(NULL);
 #ifndef __WIN__
   unlink(path);