List:Commits« Previous MessageNext Message »
From:kgeorge Date:March 26 2007 1:52pm
Subject:bk commit into 5.0 tree (gkodinov:1.2420)
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of kgeorge. When kgeorge does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-03-26 16:52:52+03:00, gkodinov@stripped +3 -0
  WL3527: 5.0 part:
  enabled the optional FOR JOIN to all the three
  clauses : USE, FORCE and IGNORE

  mysql-test/r/select.result@stripped, 2007-03-26 16:52:51+03:00, gkodinov@stripped +6 -0
    WL3527: 5.0 part: test cases

  mysql-test/t/select.test@stripped, 2007-03-26 16:52:51+03:00, gkodinov@stripped +2 -0
    WL3527: 5.0 part: test cases

  sql/sql_yacc.yy@stripped, 2007-03-26 16:52:51+03:00, gkodinov@stripped +4 -8
    WL3527: 5.0 part:
    enabled the optional FOR JOIN to all the three
    clauses : USE, FORCE and IGNORE

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	gkodinov
# Host:	magare.gmz
# Root:	/home/kgeorge/mysql/work/WL3527-5.0-opt

--- 1.512/sql/sql_yacc.yy	2007-03-22 10:21:04 +02:00
+++ 1.513/sql/sql_yacc.yy	2007-03-26 16:52:51 +03:00
@@ -1092,7 +1092,7 @@ bool my_yyoverflow(short **a, YYSTYPE **
 	key_alg opt_btree_or_rtree
 
 %type <string_list>
-	key_usage_list key_usage_list_inner using_list
+	key_usage_list using_list
 
 %type <key_part>
 	key_part
@@ -5907,19 +5907,15 @@ opt_key_definition:
 	    sel->use_index_ptr= &sel->use_index;
 	    sel->table_join_options|= TL_OPTION_FORCE_INDEX;
 	  }
-	| IGNORE_SYM key_or_index opt_for_join key_usage_list_inner
+	| IGNORE_SYM key_usage_list
 	  {
 	    SELECT_LEX *sel= Select;
-	    sel->ignore_index= *$4;
+	    sel->ignore_index= *$2;
 	    sel->ignore_index_ptr= &sel->ignore_index;
 	  };
 
 key_usage_list:
-	key_or_index key_usage_list_inner
-        { $$= $2; }
-	;
-
-key_usage_list_inner:
+        key_or_index opt_for_join      
 	{ Select->interval_list.empty(); }
         '(' key_list_or_empty ')'
         { $$= &Select->interval_list; }

--- 1.153/mysql-test/r/select.result	2007-03-12 11:24:06 +02:00
+++ 1.154/mysql-test/r/select.result	2007-03-26 16:52:51 +03:00
@@ -3636,6 +3636,12 @@ id	select_type	table	type	possible_keys	
 EXPLAIN SELECT 1 FROM t1 IGNORE INDEX FOR JOIN (a) WHERE a = 1;
 id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra
 1	SIMPLE	t1	ALL	NULL	NULL	NULL	NULL	2	Using where
+EXPLAIN SELECT 1 FROM t1 USE INDEX FOR JOIN (a) WHERE a = 1;
+id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra
+1	SIMPLE	t1	ref	a	a	5	const	1	Using where; Using index
+EXPLAIN SELECT 1 FROM t1 FORCE INDEX FOR JOIN (a) WHERE a = 1;
+id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra
+1	SIMPLE	t1	ref	a	a	5	const	1	Using where; Using index
 DROP TABLE t1;
 CREATE TABLE t1 ( f1 int primary key, f2 int, f3 int, f4 int, f5 int, f6 int, checked_out int);
 CREATE TABLE t2 ( f11 int PRIMARY KEY );

--- 1.127/mysql-test/t/select.test	2007-03-12 11:24:06 +02:00
+++ 1.128/mysql-test/t/select.test	2007-03-26 16:52:51 +03:00
@@ -3111,6 +3111,8 @@ DROP TABLE t1,t2,t3;
 CREATE TABLE t1 (a INT, b INT, KEY (a)); INSERT INTO t1 VALUES (1,1),(2,2);
 EXPLAIN SELECT 1 FROM t1 WHERE a = 1;
 EXPLAIN SELECT 1 FROM t1 IGNORE INDEX FOR JOIN (a) WHERE a = 1;
+EXPLAIN SELECT 1 FROM t1 USE INDEX FOR JOIN (a) WHERE a = 1;
+EXPLAIN SELECT 1 FROM t1 FORCE INDEX FOR JOIN (a) WHERE a = 1;
 DROP TABLE t1;
 
 #
Thread
bk commit into 5.0 tree (gkodinov:1.2420)kgeorge26 Mar