From: Date: March 23 2007 10:26am
Subject: bk commit into 5.1 tree (istruewing:1.2496) BUG#26782
List-Archive: http://lists.mysql.com/commits/22736
X-Bug: 26782
Message-Id: <E1HUg2Q-0008EH-56@chilla.local>

Below is the list of changes that have just been committed into a local
5.1 repository of istruewing. When istruewing does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-03-23 10:26:14+01:00, istruewing@stripped +1 -0
  Bug#26782 - Patch: myisamchk -rq creates .MYI.MYI file on packed MyISAM tables
  After merge fix
  In conjunction with the newest 5.1 we always need to
  create a real path name to be able to detect already
  open tables.

  storage/myisam/mi_create.c@stripped, 2007-03-23 10:26:10+01:00, istruewing@stripped +12 -5
    Bug#26782 - Patch: myisamchk -rq creates .MYI.MYI file on packed MyISAM tables
    After merge fix
    In conjunction with the newest 5.1 we always need to
    create a real path name to be able to detect already
    open tables.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	istruewing
# Host:	chilla.local
# Root:	/home/mydev/mysql-5.1-bug26782

--- 1.68/storage/myisam/mi_create.c	2007-03-23 10:26:22 +01:00
+++ 1.69/storage/myisam/mi_create.c	2007-03-23 10:26:22 +01:00
@@ -573,6 +573,10 @@ int mi_create(const char *name,uint keys
 
   pthread_mutex_lock(&THR_LOCK_myisam);
 
+  /*
+    NOTE: For test_if_reopen() we need a real path name. Hence we need
+    MY_RETURN_REAL_PATH for every fn_format(filename, ...).
+  */
   if (ci->index_file_name)
   {
     char *iext= strrchr(ci->index_file_name, '.');
@@ -584,13 +588,14 @@ int mi_create(const char *name,uint keys
       if ((path= strrchr(ci->index_file_name, FN_LIBCHAR)))
         *path= '\0';
       fn_format(filename, name, ci->index_file_name, MI_NAME_IEXT,
-                MY_REPLACE_DIR | MY_UNPACK_FILENAME | MY_APPEND_EXT);
+                MY_REPLACE_DIR | MY_UNPACK_FILENAME |
+                MY_RETURN_REAL_PATH | MY_APPEND_EXT);
     }
     else
     {
       fn_format(filename, ci->index_file_name, "", MI_NAME_IEXT,
-                MY_UNPACK_FILENAME | (have_iext ? MY_REPLACE_EXT :
-                                      MY_APPEND_EXT));
+                MY_UNPACK_FILENAME | MY_RETURN_REAL_PATH |
+                (have_iext ? MY_REPLACE_EXT : MY_APPEND_EXT));
     }
     fn_format(linkname, name, "", MI_NAME_IEXT,
               MY_UNPACK_FILENAME|MY_APPEND_EXT);
@@ -606,8 +611,7 @@ int mi_create(const char *name,uint keys
     char *iext= strrchr(name, '.');
     int have_iext= iext && !strcmp(iext, MI_NAME_IEXT);
     fn_format(filename, name, "", MI_NAME_IEXT,
-              MY_UNPACK_FILENAME |
-              ((flags & HA_DONT_TOUCH_DATA) ? MY_RETURN_REAL_PATH : 0) |
+              MY_UNPACK_FILENAME | MY_RETURN_REAL_PATH |
               (have_iext ? MY_REPLACE_EXT : MY_APPEND_EXT));
     linkname_ptr=0;
     /* Replace the current file */
@@ -620,6 +624,9 @@ int mi_create(const char *name,uint keys
     A TRUNCATE command checks for the table in the cache only and could
     be fooled to believe, the table is not open.
     Pull the emergency brake in this situation. (Bug #8306)
+
+    NOTE: The filename is compared against unique_file_name of every
+    open table. Hence we need a real path here.
   */
   if (test_if_reopen(filename))
   {