List:Commits« Previous MessageNext Message »
From:jonas Date:March 22 2007 10:36am
Subject:bk commit into 5.1 tree (jonas:1.2495)
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of jonas. When jonas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-03-22 11:36:22+01:00, jonas@stripped +14 -0
  Merge perch.ndb.mysql.com:/home/jonas/src/mysql-5.1-new-ndb
  into  perch.ndb.mysql.com:/home/jonas/src/51-telco
  MERGE: 1.2473.1.33

  BitKeeper/etc/ignore@stripped, 2007-03-22 11:33:52+01:00, jonas@stripped +0 -0
    auto-union
    MERGE: 1.276.1.7

  mysql-test/mysql-test-run.pl@stripped, 2007-03-22 11:36:20+01:00, jonas@stripped +0 -1
    merge
    MERGE: 1.270.1.18

  sql/item_func.cc@stripped, 2007-03-22 11:33:59+01:00, jonas@stripped +0 -0
    Auto merged
    MERGE: 1.353.1.14

  sql/mysqld.cc@stripped, 2007-03-22 11:34:00+01:00, jonas@stripped +0 -0
    Auto merged
    MERGE: 1.621.1.1

  storage/ndb/src/kernel/blocks/dbdih/DbdihMain.cpp@stripped, 2007-03-22 11:34:00+01:00, jonas@stripped +0 -0
    Auto merged
    MERGE: 1.96.1.19

  storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp@stripped, 2007-03-22 11:34:00+01:00, jonas@stripped +0 -0
    Auto merged
    MERGE: 1.129.1.17

  storage/ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp@stripped, 2007-03-22 11:34:00+01:00, jonas@stripped +0 -0
    Auto merged
    MERGE: 1.50.1.5

  storage/ndb/src/kernel/blocks/dbtup/DbtupGen.cpp@stripped, 2007-03-22 11:34:00+01:00, jonas@stripped +0 -0
    Auto merged
    MERGE: 1.35.1.4

  storage/ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp@stripped, 2007-03-22 11:34:00+01:00, jonas@stripped +0 -0
    Auto merged
    MERGE: 1.41.1.10

  storage/ndb/src/mgmsrv/ConfigInfo.cpp@stripped, 2007-03-22 11:34:00+01:00, jonas@stripped +0 -0
    Auto merged
    MERGE: 1.94.1.10

  storage/ndb/src/mgmsrv/MgmtSrvr.cpp@stripped, 2007-03-22 11:34:00+01:00, jonas@stripped +0 -0
    Auto merged
    MERGE: 1.113.1.11

  storage/ndb/test/ndbapi/testNodeRestart.cpp@stripped, 2007-03-22 11:34:00+01:00, jonas@stripped +0 -0
    Auto merged
    MERGE: 1.36.1.14

  storage/ndb/test/run-test/daily-basic-tests.txt@stripped, 2007-03-22 11:34:00+01:00, jonas@stripped +0 -0
    Auto merged
    MERGE: 1.61.1.13

  storage/ndb/test/src/UtilTransactions.cpp@stripped, 2007-03-22 11:34:00+01:00, jonas@stripped +0 -0
    Auto merged
    MERGE: 1.27.1.1

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	jonas
# Host:	perch.ndb.mysql.com
# Root:	/home/jonas/src/51-telco/RESYNC

--- 1.359/sql/item_func.cc	2007-03-22 11:36:28 +01:00
+++ 1.360/sql/item_func.cc	2007-03-22 11:36:28 +01:00
@@ -435,7 +435,7 @@
 
   switch (result_type()) {
   case INT_RESULT:
-    if (max_length > 11)
+    if (max_length > MY_INT32_NUM_DECIMAL_DIGITS)
       field= new Field_longlong(max_length, maybe_null, name, unsigned_flag);
     else
       field= new Field_long(max_length, maybe_null, name, unsigned_flag);
@@ -2338,7 +2338,8 @@
 
 void Item_func_locate::fix_length_and_dec()
 {
-  maybe_null=0; max_length=11;
+  maybe_null= 0;
+  max_length= MY_INT32_NUM_DECIMAL_DIGITS;
   agg_arg_charsets(cmp_collation, args, 2, MY_COLL_CMP_CONV, 1);
 }
 

--- 1.622/sql/mysqld.cc	2007-03-22 11:36:29 +01:00
+++ 1.623/sql/mysqld.cc	2007-03-22 11:36:29 +01:00
@@ -421,7 +421,7 @@
 char opt_ndb_constrbuf[1024];
 unsigned opt_ndb_constrbuf_len= 0;
 my_bool	opt_ndb_shm, opt_ndb_optimized_node_selection;
-ulong opt_ndb_cache_check_time;
+ulong opt_ndb_cache_check_time, opt_ndb_wait_connected;
 const char *opt_ndb_mgmd;
 ulong opt_ndb_nodeid;
 ulong ndb_extra_logging;
@@ -4902,6 +4902,7 @@
   OPT_NDB_USE_EXACT_COUNT, OPT_NDB_USE_TRANSACTIONS,
   OPT_NDB_FORCE_SEND, OPT_NDB_AUTOINCREMENT_PREFETCH_SZ,
   OPT_NDB_SHM, OPT_NDB_OPTIMIZED_NODE_SELECTION, OPT_NDB_CACHE_CHECK_TIME,
+  OPT_NDB_WAIT_CONNECTED,
   OPT_NDB_MGMD, OPT_NDB_NODEID,
   OPT_NDB_DISTRIBUTION,
   OPT_NDB_INDEX_STAT_ENABLE,
@@ -5632,6 +5633,12 @@
    (gptr*) &global_system_variables.ndb_use_copying_alter_table,
    (gptr*) &global_system_variables.ndb_use_copying_alter_table,
    0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0},  
+#ifdef WITH_NDBCLUSTER_STORAGE_ENGINE
+  { "ndb-wait-connected", OPT_NDB_WAIT_CONNECTED,
+    "Time (in seconds) for mysqld to wait for connection to cluster management and data nodes.",
+    (gptr*) &opt_ndb_wait_connected, (gptr*) &opt_ndb_wait_connected,
+    0, GET_ULONG, REQUIRED_ARG, 0, 0, LONG_TIMEOUT, 0, 0, 0},
+#endif
   {"new", 'n', "Use very new possible 'unsafe' functions.",
    (gptr*) &global_system_variables.new_mode,
    (gptr*) &max_system_variables.new_mode,

--- 1.275/mysql-test/mysql-test-run.pl	2007-03-22 11:36:29 +01:00
+++ 1.276/mysql-test/mysql-test-run.pl	2007-03-22 11:36:29 +01:00
@@ -354,7 +354,7 @@
 sub ndbd_start ($$$);
 sub ndb_mgmd_start ($);
 sub mysqld_start ($$$);
-sub mysqld_arguments ($$$$$);
+sub mysqld_arguments ($$$$);
 sub stop_all_servers ();
 sub run_mysqltest ($);
 sub usage ($);
@@ -902,7 +902,7 @@
   # --------------------------------------------------------------------------
   if ( $opt_with_ndbcluster and !$opt_bench)
   {
-    mtr_error("Can only use --with-ndbcluster togheter with --bench");
+    mtr_error("Can only use --with-ndbcluster together with --bench");
   }
 
   if ( $opt_ndbconnectstring )
@@ -1495,9 +1495,17 @@
 
   if (!$opt_extern)
   {
-  # Look for SQL scripts directory
-  $path_sql_dir= mtr_path_exists("$glob_basedir/share",
-				 "$glob_basedir/scripts");
+    # Look for SQL scripts directory
+    if ( mtr_file_exists("$path_share/mysql_system_tables.sql") ne "")
+    {
+      # The SQL scripts are in path_share
+      $path_sql_dir= $path_share;
+    }
+    else
+    {
+      $path_sql_dir= mtr_path_exists("$glob_basedir/share",
+				     "$glob_basedir/scripts");
+    }
 
     if ( $mysql_version_id >= 50100 )
     {
@@ -3628,21 +3636,20 @@
 }
 
 
-sub mysqld_arguments ($$$$$) {
+sub mysqld_arguments ($$$$) {
   my $args=              shift;
-  my $type=              shift;
-  my $idx=               shift;
+  my $mysqld=            shift;
   my $extra_opt=         shift;
   my $slave_master_info= shift;
 
+  my $idx= $mysqld->{'idx'};
   my $sidx= "";                 # Index as string, 0 is empty string
-  if ( $idx > 0 )
+  if ( $idx> 0 )
   {
-    $sidx= "$idx";
+    $sidx= $idx;
   }
 
   my $prefix= "";               # If mysqltest server arg
-
   if ( $glob_use_embedded_server )
   {
     $prefix= "--server-arg=";
@@ -3679,36 +3686,53 @@
     }
   }
 
+  mtr_add_arg($args, "%s--pid-file=%s", $prefix,
+	      $mysqld->{'path_pid'});
+
+  mtr_add_arg($args, "%s--port=%d", $prefix,
+                $mysqld->{'port'});
+
+  mtr_add_arg($args, "%s--socket=%s", $prefix,
+	      $mysqld->{'path_sock'});
+
+  mtr_add_arg($args, "%s--datadir=%s", $prefix,
+	      $mysqld->{'path_myddir'});
+
+
+  if ( $mysql_version_id >= 50106 )
+  {
+    # Turn on logging to bothe tables and file
+    mtr_add_arg($args, "%s--log-output=table,file", $prefix);
+  }
+
+  mtr_add_arg($args, "%s--log=%s", $prefix, $mysqld->{'path_mylog'});
+
+
   # Check if "extra_opt" contains --skip-log-bin
   my $skip_binlog= grep(/^--skip-log-bin/, @$extra_opt);
 
-  if ( $type eq 'master' )
+  if ( $mysqld->{'type'} eq 'master' )
   {
-    my $id= $idx > 0 ? $idx + 101 : 1;
-
     if (! ($opt_skip_master_binlog || $skip_binlog) )
     {
       mtr_add_arg($args, "%s--log-bin=%s/log/master-bin%s", $prefix,
                   $opt_vardir, $sidx);
     }
-    mtr_add_arg($args, "%s--pid-file=%s", $prefix,
-                $master->[$idx]->{'path_pid'});
-    mtr_add_arg($args, "%s--port=%d", $prefix,
-                $master->[$idx]->{'port'});
-    mtr_add_arg($args, "%s--server-id=%d", $prefix, $id);
-    mtr_add_arg($args, "%s--socket=%s", $prefix,
-                $master->[$idx]->{'path_sock'});
-    mtr_add_arg($args, "%s--innodb_data_file_path=ibdata1:10M:autoextend", $prefix);
+
+    mtr_add_arg($args, "%s--server-id=%d", $prefix,
+	       $idx > 0 ? $idx + 101 : 1);
+
+    mtr_add_arg($args, "%s--innodb_data_file_path=ibdata1:10M:autoextend",
+		$prefix);
+
     mtr_add_arg($args, "%s--local-infile", $prefix);
-    mtr_add_arg($args, "%s--datadir=%s", $prefix,
-                $master->[$idx]->{'path_myddir'});
 
     if ( $idx > 0 or !$use_innodb)
     {
       mtr_add_arg($args, "%s--skip-innodb", $prefix);
     }
 
-    my $cluster= $clusters->[$master->[$idx]->{'cluster'}];
+    my $cluster= $clusters->[$mysqld->{'cluster'}];
     if ( $opt_skip_ndbcluster ||
 	 !$cluster->{'pid'})
     {
@@ -3726,28 +3750,14 @@
       }
     }
 
-    if ( $mysql_version_id <= 50106 )
-    {
-      # Force mysqld to use log files up until 5.1.6
-      mtr_add_arg($args, "%s--log=%s", $prefix, $master->[0]->{'path_mylog'});
-    }
-    else
-    {
-      # Turn on logging, will be sent to tables
-      mtr_add_arg($args, "%s--log=", $prefix);
-    }
-
       mtr_add_arg($args, "%s--plugin_dir=%s", $prefix,
 		  dirname($lib_example_plugin));
   }
-
-  if ( $type eq 'slave' )
+  else
   {
-    my $slave_server_id=  2 + $idx;
-    my $slave_rpl_rank= $slave_server_id;
+    mtr_error("unknown mysqld type")
+      unless $mysqld->{'type'} eq 'slave';
 
-    mtr_add_arg($args, "%s--datadir=%s", $prefix,
-                $slave->[$idx]->{'path_myddir'});
     mtr_add_arg($args, "%s--init-rpl-role=slave", $prefix);
     if (! ( $opt_skip_slave_binlog || $skip_binlog ))
     {
@@ -3757,18 +3767,14 @@
     }
 
     mtr_add_arg($args, "%s--master-retry-count=10", $prefix);
-    mtr_add_arg($args, "%s--pid-file=%s", $prefix,
-                $slave->[$idx]->{'path_pid'});
-    mtr_add_arg($args, "%s--port=%d", $prefix,
-                $slave->[$idx]->{'port'});
+
     mtr_add_arg($args, "%s--relay-log=%s/log/slave%s-relay-bin", $prefix,
                 $opt_vardir, $sidx);
     mtr_add_arg($args, "%s--report-host=127.0.0.1", $prefix);
     mtr_add_arg($args, "%s--report-port=%d", $prefix,
-                $slave->[$idx]->{'port'});
+                $mysqld->{'port'});
     mtr_add_arg($args, "%s--report-user=root", $prefix);
     mtr_add_arg($args, "%s--skip-innodb", $prefix);
-    mtr_add_arg($args, "%s--skip-ndbcluster", $prefix);
     mtr_add_arg($args, "%s--skip-slave-start", $prefix);
 
     # Directory where slaves find the dumps generated by "load data"
@@ -3777,8 +3783,6 @@
     my $slave_load_path= "../tmp";
     mtr_add_arg($args, "%s--slave-load-tmpdir=%s", $prefix,
                 $slave_load_path);
-    mtr_add_arg($args, "%s--socket=%s", $prefix,
-                $slave->[$idx]->{'path_sock'});
     mtr_add_arg($args, "%s--set-variable=slave_net_timeout=10", $prefix);
 
     if ( @$slave_master_info )
@@ -3796,13 +3800,16 @@
       mtr_add_arg($args, "%s--master-password=", $prefix);
       mtr_add_arg($args, "%s--master-port=%d", $prefix,
                   $master->[0]->{'port'}); # First master
+
+      my $slave_server_id=  2 + $idx;
+      my $slave_rpl_rank= $slave_server_id;
       mtr_add_arg($args, "%s--server-id=%d", $prefix, $slave_server_id);
       mtr_add_arg($args, "%s--rpl-recovery-rank=%d", $prefix, $slave_rpl_rank);
     }
 
     if ( $opt_skip_ndbcluster_slave ||
-         $slave->[$idx]->{'cluster'} == -1 ||
-	 !$clusters->[$slave->[$idx]->{'cluster'}]->{'pid'} )
+         $mysqld->{'cluster'} == -1 ||
+	 !$clusters->[$mysqld->{'cluster'}]->{'pid'} )
     {
       mtr_add_arg($args, "%s--skip-ndbcluster", $prefix);
     }
@@ -3810,42 +3817,21 @@
     {
       mtr_add_arg($args, "%s--ndbcluster", $prefix);
       mtr_add_arg($args, "%s--ndb-connectstring=%s", $prefix,
-		  $clusters->[$slave->[$idx]->{'cluster'}]->{'connect_string'});
+		  $clusters->[$mysqld->{'cluster'}]->{'connect_string'});
       mtr_add_arg($args, "%s--ndb-wait-connected=20", $prefix);
       if ( $mysql_version_id >= 50100 )
       {
 	mtr_add_arg($args, "%s--ndb-extra-logging", $prefix);
       }
     }
-
-    if ( $mysql_version_id <= 50106 )
-    {
-      # Force mysqld to use log files up until 5.1.6
-      mtr_add_arg($args, "%s--log=%s", $prefix, $master->[0]->{'path_mylog'});
-    }
-    else
-    {
-      # Turn on logging, will be sent to tables
-      mtr_add_arg($args, "%s--log=", $prefix);
-    }
-
   } # end slave
 
   if ( $opt_debug )
   {
-    if ( $type eq 'master' )
-    {
-      mtr_add_arg($args, "%s--debug=d:t:i:A,%s/log/master%s.trace",
-                  $prefix, $path_vardir_trace, $sidx);
-    }
-    if ( $type eq 'slave' )
-    {
-      mtr_add_arg($args, "%s--debug=d:t:i:A,%s/log/slave%s.trace",
-                  $prefix, $path_vardir_trace, $sidx);
-    }
+    mtr_add_arg($args, "%s--debug=d:t:i:A,%s/log/%s%s.trace",
+		$prefix, $path_vardir_trace, $mysqld->{'type'}, $sidx);
   }
 
-  # FIXME always set nowdays??? SMALL_SERVER
   mtr_add_arg($args, "%s--key_buffer_size=1M", $prefix);
   mtr_add_arg($args, "%s--sort_buffer=256K", $prefix);
   mtr_add_arg($args, "%s--max_heap_table_size=1M", $prefix);
@@ -3871,18 +3857,10 @@
     mtr_add_arg($args, "%s--gdb", $prefix);
   }
 
-  # If we should run all tests cases, we will use a local server for that
-
-  if ( -w "/" )
-  {
-    # We are running as root;  We need to add the --root argument
-    mtr_add_arg($args, "%s--user=root", $prefix);
-  }
-
   my $found_skip_core= 0;
   foreach my $arg ( @opt_extra_mysqld_opt, @$extra_opt )
   {
-    # Allow --skip-core-file to be set in master.opt file
+    # Allow --skip-core-file to be set in <testname>-[master|slave].opt file
     if ($arg eq "--skip-core-file")
     {
       $found_skip_core= 1;
@@ -3906,7 +3884,7 @@
     mtr_add_arg($args, "%s--rpl-recovery-rank=1", $prefix);
     mtr_add_arg($args, "%s--init-rpl-role=master", $prefix);
   }
-  elsif ( $type eq 'master' )
+  elsif ( $mysqld->{'type'} eq 'master' )
   {
     mtr_add_arg($args, "%s--open-files-limit=1024", $prefix);
   }
@@ -3957,7 +3935,7 @@
     valgrind_arguments($args, \$exe);
   }
 
-  mysqld_arguments($args,$type,$idx,$extra_opt,$slave_master_info);
+  mysqld_arguments($args,$mysqld,$extra_opt,$slave_master_info);
 
   if ( $opt_gdb || $opt_manual_gdb)
   {
@@ -4702,7 +4680,7 @@
 
   if ( $glob_use_embedded_server )
   {
-    mysqld_arguments($args,'master',0,$tinfo->{'master_opt'},[]);
+    mysqld_arguments($args,$master->[0],$tinfo->{'master_opt'},[]);
   }
 
   # ----------------------------------------------------------------------

--- 1.281/BitKeeper/etc/ignore	2007-03-22 11:36:29 +01:00
+++ 1.282/BitKeeper/etc/ignore	2007-03-22 11:36:29 +01:00
@@ -1763,7 +1763,9 @@
 netware/.deps/mysql_install_db.Po
 netware/.deps/mysql_test_run.Po
 netware/.deps/mysqld_safe.Po
+netware/init_db.sql
 netware/libmysql.imp
+netware/test_db.sql
 pack_isam/*.ds?
 perror/*.ds?
 perror/*.vcproj
Thread
bk commit into 5.1 tree (jonas:1.2495)jonas22 Mar