List:Commits« Previous MessageNext Message »
From:msvensson Date:February 7 2006 4:57pm
Subject:bk commit into 5.1 tree (msvensson:1.2081)
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of msvensson. When msvensson does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2081 06/02/07 17:57:26 msvensson@neptunus.(none) +13 -0
  Merge neptunus.(none):/home/msvensson/mysql/mysqltestrun_check_testcases/my51-mysqltestrun_check_testcases
  into  neptunus.(none):/home/msvensson/mysql/mysql-5.1-new

  mysql-test/r/trigger-compat.result
    1.4 06/02/07 17:57:23 msvensson@neptunus.(none) +2 -2
    Merge 5.0 -> 5.1

  mysql-test/t/view_grant.test
    1.11 06/02/07 17:56:23 msvensson@neptunus.(none) +0 -0
    Auto merged

  mysql-test/t/trigger-compat.test
    1.5 06/02/07 17:56:23 msvensson@neptunus.(none) +0 -0
    Auto merged

  mysql-test/t/sp-security.test
    1.27 06/02/07 17:56:23 msvensson@neptunus.(none) +0 -0
    Auto merged

  mysql-test/t/read_only.test
    1.3 06/02/07 17:56:23 msvensson@neptunus.(none) +0 -0
    Auto merged

  mysql-test/t/query_cache.test
    1.55 06/02/07 17:56:23 msvensson@neptunus.(none) +0 -0
    Auto merged

  mysql-test/r/view_grant.result
    1.12 06/02/07 17:56:23 msvensson@neptunus.(none) +0 -0
    Auto merged

  mysql-test/r/variables.result
    1.79 06/02/07 17:56:22 msvensson@neptunus.(none) +0 -0
    Auto merged

  mysql-test/r/sp-security.result
    1.24 06/02/07 17:56:22 msvensson@neptunus.(none) +0 -0
    Auto merged

  mysql-test/r/rpl_loaddata_m.result
    1.18 06/02/07 17:56:22 msvensson@neptunus.(none) +0 -0
    Auto merged

  mysql-test/r/query_cache.result
    1.70 06/02/07 17:56:22 msvensson@neptunus.(none) +0 -0
    Auto merged

  mysql-test/r/ps_1general.result
    1.55 06/02/07 17:56:22 msvensson@neptunus.(none) +0 -0
    Auto merged

  mysql-test/mysql-test-run.pl
    1.62 06/02/07 17:56:22 msvensson@neptunus.(none) +0 -0
    Auto merged

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	msvensson
# Host:	neptunus.(none)
# Root:	/home/msvensson/mysql/mysql-5.1-new/RESYNC

--- 1.3/mysql-test/r/trigger-compat.result	2006-02-01 11:28:40 +01:00
+++ 1.4/mysql-test/r/trigger-compat.result	2006-02-07 17:57:23 +01:00
@@ -35,3 +35,13 @@
 TRIGGER_CATALOG	TRIGGER_SCHEMA	TRIGGER_NAME	EVENT_MANIPULATION	EVENT_OBJECT_CATALOG	EVENT_OBJECT_SCHEMA	EVENT_OBJECT_TABLE	ACTION_ORDER	ACTION_CONDITION	ACTION_STATEMENT	ACTION_ORIENTATION	ACTION_TIMING	ACTION_REFERENCE_OLD_TABLE	ACTION_REFERENCE_NEW_TABLE	ACTION_REFERENCE_OLD_ROW	ACTION_REFERENCE_NEW_ROW	CREATED	SQL_MODE	DEFINER
 NULL	mysqltest_db1	wl2818_trg1	INSERT	NULL	mysqltest_db1	t1	0	NULL	INSERT INTO t2 VALUES(CURRENT_USER())	ROW	BEFORE	NULL	NULL	OLD	NEW	NULL		
 NULL	mysqltest_db1	wl2818_trg2	INSERT	NULL	mysqltest_db1	t1	0	NULL	INSERT INTO t2 VALUES(CURRENT_USER())	ROW	AFTER	NULL	NULL	OLD	NEW	NULL		mysqltest_dfn@localhost
+DROP TRIGGER wl2818_trg1;
+Warnings:
+Warning	1454	No definer attribute for trigger 'mysqltest_db1'.'wl2818_trg1'. The trigger will be activated under the authorization of the invoker, which may have insufficient privileges. Please recreate the trigger.
+DROP TRIGGER wl2818_trg2;
+use mysqltest_db1;
+DROP TABLE t1;
+DROP TABLE t2;
+DROP USER mysqltest_dfn@localhost;
+DROP USER mysqltest_inv@localhost;
+DROP DATABASE mysqltest_db1;

--- 1.4/mysql-test/t/trigger-compat.test	2006-02-01 11:28:40 +01:00
+++ 1.5/mysql-test/t/trigger-compat.test	2006-02-07 17:56:23 +01:00
@@ -80,3 +80,16 @@
 --echo
 
 SELECT * FROM INFORMATION_SCHEMA.TRIGGERS ORDER BY trigger_name;
+
+# Clean up
+DROP TRIGGER wl2818_trg1;
+DROP TRIGGER wl2818_trg2;
+disconnect wl2818_definer_con;
+connection default;
+use mysqltest_db1;
+DROP TABLE t1;
+DROP TABLE t2;
+DROP USER mysqltest_dfn@localhost;
+DROP USER mysqltest_inv@localhost;
+DROP DATABASE mysqltest_db1;
+

--- 1.54/mysql-test/r/ps_1general.result	2006-01-12 19:50:30 +01:00
+++ 1.55/mysql-test/r/ps_1general.result	2006-02-07 17:56:22 +01:00
@@ -785,4 +785,4 @@
 execute stmt1 ;
 prepare stmt1 from ' select * from t5 ' ;
 execute stmt1 ;
-drop table t5, t9;
+drop table t1, t5, t9;

--- 1.2/mysql-test/t/read_only.test	2006-01-04 11:18:54 +01:00
+++ 1.3/mysql-test/t/read_only.test	2006-02-07 17:56:23 +01:00
@@ -104,3 +104,5 @@
 connection default;
 drop table t1,t2;
 drop user test@localhost;
+
+set global read_only=0;

--- 1.11/mysql-test/r/view_grant.result	2006-02-02 09:59:18 +01:00
+++ 1.12/mysql-test/r/view_grant.result	2006-02-07 17:56:23 +01:00
@@ -9,6 +9,7 @@
 show grants for test@localhost;
 Grants for test@localhost
 GRANT USAGE ON *.* TO 'test'@'localhost'
+drop user test@localhost;
 create database mysqltest;
 create table mysqltest.t1 (a int, b int);
 create table mysqltest.t2 (a int, b int);

--- 1.10/mysql-test/t/view_grant.test	2006-01-19 10:25:04 +01:00
+++ 1.11/mysql-test/t/view_grant.test	2006-02-07 17:56:23 +01:00
@@ -12,6 +12,8 @@
 show grants for test@localhost;
 revoke create view on test.* from test@localhost;
 show grants for test@localhost;
+# The grant above creates a new user test@localhost, delete it
+drop user test@localhost;
 
 # grant create view test
 #

--- 1.61/mysql-test/mysql-test-run.pl	2006-02-06 15:42:18 +01:00
+++ 1.62/mysql-test/mysql-test-run.pl	2006-02-07 17:56:22 +01:00
@@ -246,6 +246,7 @@
 our $opt_old_master;
 
 our $opt_record;
+our $opt_check_testcases;
 
 our $opt_result_ext;
 
@@ -571,6 +572,7 @@
 
              # Test case authoring
              'record'                   => \$opt_record,
+             'check-testcases'          => \$opt_check_testcases,
 
              # ???
              'mysqld=s'                 => \@opt_extra_mysqld_opt,
@@ -2730,6 +2732,54 @@
   $instance_manager->{'pid'} = undef;
 }
 
+#
+# Run include/check-testcase.test
+# Before a testcase, run in record mode, save result file to var
+# After testcase, run and compare with the recorded file, they should be equal!
+#
+sub run_check_testcase ($) {
+
+  my $mode=     shift;
+
+  my $args;
+  mtr_init_args(\$args);
+
+  mtr_add_arg($args, "--no-defaults");
+  mtr_add_arg($args, "--silent");
+  mtr_add_arg($args, "-v");
+  mtr_add_arg($args, "--skip-safemalloc");
+  mtr_add_arg($args, "--tmpdir=%s", $opt_tmpdir);
+
+  mtr_add_arg($args, "--socket=%s", $master->[0]->{'path_mysock'});
+  mtr_add_arg($args, "--port=%d", $master->[0]->{'path_myport'});
+  mtr_add_arg($args, "--database=test");
+  mtr_add_arg($args, "--user=%s", $opt_user);
+  mtr_add_arg($args, "--password=");
+
+  mtr_add_arg($args, "-R");
+  mtr_add_arg($args, "$opt_vardir/tmp/check-testcase.result");
+
+  if ( $mode eq "before" )
+  {
+    mtr_add_arg($args, "--record");
+  }
+
+  my $res = mtr_run_test($exe_mysqltest,$args,
+	        "include/check-testcase.test", "", "", "");
+
+  if ( $res == 1  and $mode = "after")
+  {
+    mtr_run("diff",["-u",
+		    "$opt_vardir/tmp/check-testcase.result",
+		    "$opt_vardir/tmp/check-testcase.reject"],
+	    "", "", "", "");
+  }
+  elsif ( $res )
+  {
+    mtr_error("Could not execute 'check-testcase' $mode testcase");
+  }
+}
+
 sub run_mysqltest ($) {
   my $tinfo=       shift;
 
@@ -2983,7 +3033,18 @@
     mtr_add_arg($args, "--record");
   }
 
-  return mtr_run_test($exe,$args,$tinfo->{'path'},"",$path_timefile,"");
+  if ( $opt_check_testcases )
+  {
+    run_check_testcase("before");
+  }
+
+  my $res = mtr_run_test($exe,$args,$tinfo->{'path'},"",$path_timefile,"");
+
+  if ( $opt_check_testcases )
+  {
+    run_check_testcase("after");
+  }
+  return $res;
 }
 
 
@@ -3067,6 +3128,7 @@
 Options for test case authoring
 
   record TESTNAME       (Re)genereate the result file for TESTNAME
+  check-testcases       Check testcases for sideeffects
 
 Options that pass on options
 

--- 1.78/mysql-test/r/variables.result	2006-02-02 09:59:18 +01:00
+++ 1.79/mysql-test/r/variables.result	2006-02-07 17:56:22 +01:00
@@ -71,6 +71,7 @@
 1	Bozo	USA
 4	Mr. Floppy	GB
 drop table t1;
+set GLOBAL max_join_size=10;
 set max_join_size=100;
 show variables like 'max_join_size';
 Variable_name	Value

--- 1.69/mysql-test/r/query_cache.result	2006-01-19 10:25:04 +01:00
+++ 1.70/mysql-test/r/query_cache.result	2006-02-07 17:56:22 +01:00
@@ -1076,6 +1076,7 @@
 1	2
 2	2
 drop procedure p1//
+drop function f1//
 drop table t1//
 flush query cache;
 reset query cache;

--- 1.54/mysql-test/t/query_cache.test	2006-01-04 11:18:53 +01:00
+++ 1.55/mysql-test/t/query_cache.test	2006-02-07 17:56:23 +01:00
@@ -787,6 +787,7 @@
 end//
 call p1()//
 drop procedure p1//
+drop function f1//
 
 drop table t1//
 delimiter ;//

--- 1.23/mysql-test/r/sp-security.result	2005-12-15 15:23:09 +01:00
+++ 1.24/mysql-test/r/sp-security.result	2006-02-07 17:56:22 +01:00
@@ -134,7 +134,11 @@
 select type,db,name from mysql.proc;
 type	db	name
 delete from mysql.user where user='user1' or user='user2';
+delete from mysql.user where user='' and host='%';
 delete from mysql.procs_priv where user='user1' or user='user2';
+delete from mysql.procs_priv where user='' and host='%';
+delete from mysql.db where user='user2';
+flush privileges;
 grant usage on *.* to usera@localhost;
 grant usage on *.* to userb@localhost;
 grant usage on *.* to userc@localhost;
@@ -195,6 +199,9 @@
 drop database sptest;
 delete from mysql.user where user='usera' or user='userb' or user='userc';
 delete from mysql.procs_priv where user='usera' or user='userb' or user='userc';
+delete from mysql.tables_priv where user='usera';
+flush privileges;
+drop table t1;
 drop function if exists bug_9503;
 create database mysqltest//
 use mysqltest//

--- 1.26/mysql-test/t/sp-security.test	2005-12-15 15:23:09 +01:00
+++ 1.27/mysql-test/t/sp-security.test	2006-02-07 17:56:23 +01:00
@@ -196,7 +196,6 @@
 call q();
 select * from t2;
 
-
 #
 # BUG#6030: Stored procedure has no appropriate DROP privilege
 # (or ALTER for that matter)
@@ -233,9 +232,13 @@
 select type,db,name from mysql.proc;
 # Get rid of the users
 delete from mysql.user where user='user1' or user='user2';
+delete from mysql.user where user='' and host='%';
 # And any routine privileges
 delete from mysql.procs_priv where user='user1' or user='user2';
-
+# Delete the grants to user ''@'%' that was created above
+delete from mysql.procs_priv where user='' and host='%';
+delete from mysql.db where user='user2';
+flush privileges;
 #
 # Test the new security acls
 #
@@ -304,6 +307,9 @@
 drop database sptest;
 delete from mysql.user where user='usera' or user='userb' or user='userc';
 delete from mysql.procs_priv where user='usera' or user='userb' or user='userc';
+delete from mysql.tables_priv where user='usera';
+flush privileges;
+drop table t1;
 
 #
 # BUG#9503: reseting correct parameters of thread after error in SP function
Thread
bk commit into 5.1 tree (msvensson:1.2081)msvensson7 Feb