From: Date: March 21 2007 3:27pm
Subject: bk commit into 5.1 tree (jonas:1.2127) BUG#27283
List-Archive: http://lists.mysql.com/commits/22489
X-Bug: 27283
Message-Id: <20070321142703.EE47E83DBC@perch.ndb.mysql.com>

Below is the list of changes that have just been committed into a local
5.1 repository of jonas. When jonas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-03-21 15:27:00+01:00, jonas@stripped +4 -0
  ndb - bug#27283
    Additional fix for 2-node case

  storage/ndb/src/kernel/blocks/dbdih/Dbdih.hpp@stripped, 2007-03-21 15:26:58+01:00, jonas@stripped +2 -0
    Add error insert ref for errcode = 7181

  storage/ndb/src/kernel/blocks/dbdih/DbdihMain.cpp@stripped, 2007-03-21 15:26:58+01:00, jonas@stripped +6 -1
    Make GSN_GCP_NODEFINISH always be sent to DIH node requesting it

  storage/ndb/src/kernel/blocks/dbtc/Dbtc.hpp@stripped, 2007-03-21 15:26:58+01:00, jonas@stripped +3 -0
    Make GSN_GCP_NODEFINISH always be sent to DIH node requesting it

  storage/ndb/src/kernel/blocks/dbtc/DbtcMain.cpp@stripped, 2007-03-21 15:26:59+01:00, jonas@stripped +2 -0
    Make GSN_GCP_NODEFINISH always be sent to DIH node requesting it

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	jonas
# Host:	perch.ndb.mysql.com
# Root:	/home/jonas/src/drop5

--- 1.16/storage/ndb/src/kernel/blocks/dbdih/Dbdih.hpp	2007-03-21 15:27:03 +01:00
+++ 1.17/storage/ndb/src/kernel/blocks/dbdih/Dbdih.hpp	2007-03-21 15:27:03 +01:00
@@ -1603,6 +1603,8 @@
   void startInfoReply(Signal *, Uint32 nodeId);
 
   void dump_replica_info();
+
+  Uint32 c_error_7181_ref;
 };
 
 #if (DIH_CDATA_SIZE < _SYSFILE_SIZE32)

--- 1.60/storage/ndb/src/kernel/blocks/dbdih/DbdihMain.cpp	2007-03-21 15:27:03 +01:00
+++ 1.61/storage/ndb/src/kernel/blocks/dbdih/DbdihMain.cpp	2007-03-21 15:27:03 +01:00
@@ -4805,6 +4805,7 @@
   {
     ndbout_c("execGCP_TCFINISHED in MASTER_GCPREQ");
     CLEAR_ERROR_INSERT_VALUE;
+    signal->theData[0] = c_error_7181_ref;
     signal->theData[1] = coldgcp;
     execGCP_TCFINISHED(signal);
   }
@@ -4880,6 +4881,7 @@
   {
     ndbout_c("execGCP_TCFINISHED in MASTER_GCPREQ");
     CLEAR_ERROR_INSERT_VALUE;
+    signal->theData[0] = c_error_7181_ref;
     signal->theData[1] = coldgcp;
     execGCP_TCFINISHED(signal);
   }
@@ -7730,6 +7732,7 @@
   cgckptflag = false;
   emptyverificbuffer(signal, true);
   cgcpParticipantState = GCP_PARTICIPANT_COMMIT_RECEIVED;
+  signal->theData[0] = calcDihBlockRef(masterNodeId);
   signal->theData[1] = coldgcp;
   sendSignal(clocaltcblockref, GSN_GCP_NOMORETRANS, signal, 2, JBB);
   return;
@@ -7739,11 +7742,13 @@
 {
   jamEntry();
   CRASH_INSERTION(7007);
+  Uint32 retRef = signal->theData[0];
   Uint32 gci = signal->theData[1];
   ndbrequire(gci == coldgcp);
 
   if (ERROR_INSERTED(7181) || ERROR_INSERTED(7182))
   {
+    c_error_7181_ref = retRef; // Save ref
     ndbout_c("killing %d", refToNode(cmasterdihref));
     signal->theData[0] = 9999;
     sendSignal(numberToRef(CMVMI, refToNode(cmasterdihref)),
@@ -7755,7 +7760,7 @@
   signal->theData[0] = cownNodeId;
   signal->theData[1] = coldgcp;
   signal->theData[2] = cfailurenr;
-  sendSignal(cmasterdihref, GSN_GCP_NODEFINISH, signal, 3, JBB);
+  sendSignal(retRef, GSN_GCP_NODEFINISH, signal, 3, JBB);
 }//Dbdih::execGCP_TCFINISHED()
 
 /*****************************************************************************/

--- 1.38/storage/ndb/src/kernel/blocks/dbtc/Dbtc.hpp	2007-03-21 15:27:03 +01:00
+++ 1.39/storage/ndb/src/kernel/blocks/dbtc/Dbtc.hpp	2007-03-21 15:27:03 +01:00
@@ -1961,5 +1961,8 @@
   // those variables should be removed and exchanged for stack
   // variable communication.
   /**************************************************************************/
+
+  Uint32 c_gcp_ref;
 };
+
 #endif

--- 1.104/storage/ndb/src/kernel/blocks/dbtc/DbtcMain.cpp	2007-03-21 15:27:03 +01:00
+++ 1.105/storage/ndb/src/kernel/blocks/dbtc/DbtcMain.cpp	2007-03-21 15:27:03 +01:00
@@ -6915,6 +6915,7 @@
 void Dbtc::execGCP_NOMORETRANS(Signal* signal) 
 {
   jamEntry();
+  c_gcp_ref = signal->theData[0];
   tcheckGcpId = signal->theData[1];
   if (cfirstgcp != RNIL) {
     jam();
@@ -9957,6 +9958,7 @@
 
 void Dbtc::gcpTcfinished(Signal* signal) 
 {
+  signal->theData[0] = c_gcp_ref;
   signal->theData[1] = tcheckGcpId;
   sendSignal(cdihblockref, GSN_GCP_TCFINISHED, signal, 2, JBB);
 }//Dbtc::gcpTcfinished()