List:Commits« Previous MessageNext Message »
From:tomas Date:March 19 2007 11:37am
Subject:bk commit into 5.1 tree (tomas:1.2478)
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of tomas. When tomas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2478 07/03/19 11:37:09 tomas@poseidon. +1 -0
  Merge poseidon.:/home/tomas/mysql-5.1
  into  poseidon.:/home/tomas/mysql-5.1-new-ndb

  sql/ha_ndbcluster.cc
    1.416 07/03/19 11:36:54 tomas@poseidon. +0 -0
    Auto merged

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	tomas
# Host:	poseidon.
# Root:	/home/tomas/mysql-5.1-new-ndb/RESYNC

--- 1.415/sql/ha_ndbcluster.cc	2007-03-16 14:01:09 +01:00
+++ 1.416/sql/ha_ndbcluster.cc	2007-03-19 11:36:54 +01:00
@@ -4822,7 +4822,8 @@ int ha_ndbcluster::create(const char *na
     if ((my_errno= create_ndb_column(col, field, create_info)))
       DBUG_RETURN(my_errno);
  
-    if (create_info->storage_media == HA_SM_DISK)
+    if (create_info->storage_media == HA_SM_DISK ||
+        create_info->tablespace)
       col.setStorageType(NdbDictionary::Column::StorageTypeDisk);
     else
       col.setStorageType(NdbDictionary::Column::StorageTypeMemory);
@@ -10614,10 +10615,23 @@ bool ha_ndbcluster::check_if_incompatibl
 
   int pk= 0;
   int ai= 0;
+
+  if (create_info->tablespace)
+    create_info->storage_media = HA_SM_DISK;
+  else
+    create_info->storage_media = HA_SM_MEMORY;
+
   for (i= 0; i < table->s->fields; i++) 
   {
     Field *field= table->field[i];
     const NDBCOL *col= tab->getColumn(i);
+    if (col->getStorageType() == NDB_STORAGETYPE_MEMORY &&
create_info->storage_media != HA_SM_MEMORY ||
+        col->getStorageType() == NDB_STORAGETYPE_DISK &&
create_info->storage_media != HA_SM_DISK)
+    {
+      DBUG_PRINT("info", ("Column storage media is changed"));
+      DBUG_RETURN(COMPATIBLE_DATA_NO);
+    }
+    
     if (field->flags & FIELD_IS_RENAMED)
     {
       DBUG_PRINT("info", ("Field has been renamed, copy table"));
Thread
bk commit into 5.1 tree (tomas:1.2478)tomas19 Mar