List:Commits« Previous MessageNext Message »
From:Martin Skold Date:March 16 2007 7:51am
Subject:bk commit into 5.1 tree (mskold:1.2485) BUG#26591
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of marty. When marty does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-03-16 08:51:29+01:00, mskold@stripped +1 -0
  bug #26591 Cluster handler does not set bits in null bytes correctly: Set filler bits and unmark the ones with values by calling field->set_notnull()

  sql/ha_ndbcluster.cc@stripped, 2007-03-16 08:51:00+01:00, mskold@stripped +6 -2
    bug #26591 Cluster handler does not set bits in null bytes correctly: Set filler bits and unmark the ones with values by calling field->set_notnull()

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	mskold
# Host:	linux.site
# Root:	/windows/Linux_space/MySQL/mysql-5.1-new-ndb

--- 1.420/sql/ha_ndbcluster.cc	2007-03-16 08:51:39 +01:00
+++ 1.421/sql/ha_ndbcluster.cc	2007-03-16 08:51:39 +01:00
@@ -3109,11 +3109,15 @@ void ndb_unpack_record(TABLE *table, Ndb
   my_bitmap_map *old_map= dbug_tmp_use_all_columns(table, table->write_set);
   DBUG_ENTER("ndb_unpack_record");
 
+ // Set filler bits
+  if (table->s->null_bytes > 0)
+       buf[table->s->null_bytes - 1]|= 256U - (1U <<
+					       table->s->last_null_bit_pos);
   // Set null flag(s)
-  bzero(buf, table->s->null_bytes);
   for ( ; field;
        p_field++, value++, field= *p_field)
   {
+    field->set_notnull(row_offset);       
     if ((*value).ptr)
     {
       if (!(field->flags & BLOB_FLAG))
@@ -3123,7 +3127,7 @@ void ndb_unpack_record(TABLE *table, Ndb
         {
           if (is_null > 0)
           {
-            DBUG_PRINT("info",("[%u] NULL",
+	    DBUG_PRINT("info",("[%u] NULL",
                                (*value).rec->getColumn()->getColumnNo()));
             field->set_null(row_offset);
           }
Thread
bk commit into 5.1 tree (mskold:1.2485) BUG#26591Martin Skold16 Mar