From: Date: March 14 2007 2:53pm
Subject: bk commit into 5.1 tree (jonas:1.2118) BUG#27087
List-Archive: http://lists.mysql.com/commits/21923
X-Bug: 27087
Message-Id: <20070314135356.D11737EFC0@perch.ndb.mysql.com>

Below is the list of changes that have just been committed into a local
5.1 repository of jonas. When jonas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-03-14 14:53:53+01:00, jonas@stripped +1 -0
  ndb - bug#27087 (wl2325-5.0)
    Make not to handle same API_FAILREQ several times

  storage/ndb/src/kernel/blocks/suma/Suma.cpp@stripped, 2007-03-14 14:53:52+01:00, jonas@stripped +15 -0
    Make not to handle same API_FAILREQ several times

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	jonas
# Host:	perch.ndb.mysql.com
# Root:	/home/jonas/src/drop5

--- 1.35/storage/ndb/src/kernel/blocks/suma/Suma.cpp	2007-03-14 14:53:56 +01:00
+++ 1.36/storage/ndb/src/kernel/blocks/suma/Suma.cpp	2007-03-14 14:53:56 +01:00
@@ -545,6 +545,18 @@
   Uint32 failedApiNode = signal->theData[0];
   //BlockReference retRef = signal->theData[1];
 
+  if (c_failedApiNodes.get(failedApiNode))
+  {
+    jam();
+    return;
+  }
+
+  if (!c_subscriber_nodes.get(failedApiNode))
+  {
+    jam();
+    return;
+  }
+
   c_failedApiNodes.set(failedApiNode);
   c_connected_nodes.clear(failedApiNode);
   bool found = removeSubscribersOnNode(signal, failedApiNode);
@@ -558,9 +570,12 @@
   Ptr<Gcp_record> gcp;
   for(c_gcp_list.first(gcp); !gcp.isNull(); c_gcp_list.next(gcp))
   {
+    jam();
     ack->rep.gci = gcp.p->m_gci;
     if(gcp.p->m_subscribers.get(failedApiNode))
     {
+      jam();
+      gcp.p->m_subscribers.clear(failedApiNode);
       ack->rep.senderRef = numberToRef(0, failedApiNode);
       sendSignal(SUMA_REF, GSN_SUB_GCP_COMPLETE_ACK, signal, 
 		 SubGcpCompleteAck::SignalLength, JBB);