List:Commits« Previous MessageNext Message »
From:pekka Date:February 5 2006 10:52pm
Subject:bk commit into 5.1 tree (pekka:1.2132)
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of pekka. When pekka does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2132 06/02/05 23:51:47 pekka@stripped +1 -0
  ndb - TUP scan: unlock outstanding locks on scan close (lost+found patch)

  storage/ndb/src/kernel/blocks/dbtup/DbtupScan.cpp
    1.8 06/02/05 23:50:33 pekka@stripped +17 -0
    unlock outstanding locks on scan close

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	pekka
# Host:	orca.ndb.mysql.com
# Root:	/space/pekka/ndb/version/my51

--- 1.7/storage/ndb/src/kernel/blocks/dbtup/DbtupScan.cpp	2006-01-11 09:26:03 +01:00
+++ 1.8/storage/ndb/src/kernel/blocks/dbtup/DbtupScan.cpp	2006-02-05 23:50:33 +01:00
@@ -895,6 +895,23 @@
 void
 Dbtup::scanClose(Signal* signal, ScanOpPtr scanPtr)
 {
+  ScanOp& scan = *scanPtr.p;
+  ndbrequire(! (scan.m_bits & ScanOp::SCAN_LOCK_WAIT) && scan.m_accLockOp == RNIL);
+  // unlock all not unlocked by LQH
+  LocalDLFifoList<ScanLock> list(c_scanLockPool, scan.m_accLockOps);
+  ScanLockPtr lockPtr;
+  while (list.first(lockPtr)) {
+    jam();
+    AccLockReq* const lockReq = (AccLockReq*)signal->getDataPtrSend();
+    lockReq->returnCode = RNIL;
+    lockReq->requestInfo = AccLockReq::Abort;
+    lockReq->accOpPtr = lockPtr.p->m_accLockOp;
+    EXECUTE_DIRECT(DBACC, GSN_ACC_LOCKREQ, signal, AccLockReq::UndoSignalLength);
+    jamEntry();
+    ndbrequire(lockReq->returnCode == AccLockReq::Success);
+    list.release(lockPtr);
+  }
+  // send conf
   NextScanConf* const conf = (NextScanConf*)signal->getDataPtrSend();
   conf->scanPtr = scanPtr.p->m_userPtr;
   conf->accOperationPtr = RNIL;
Thread
bk commit into 5.1 tree (pekka:1.2132)pekka5 Feb