bk commit into 5.1 tree (mats:1.2474) BUG#26591

[Mats Kindahl]

Below is the list of changes that have just been committed into a local
5.1 repository of mats. When mats does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-03-08 09:06:06+01:00, mats@romeo.(none) +1 -0
  Bug #26591:
    Cluster handler does not set bits in null bytes correctly
  
  The filler bits and the X bit of the null bytes were not set correctly
  inside ndb_unpack_record(), causing row-based replication to fail since
  it compares the records directly.

  sql/ha_ndbcluster.cc@stripped, 2007-03-08 09:06:02+01:00, mats@romeo.(none) +12 -0
    ndb_unpack_record() does not set filler bits and X bit of null bytes
    corretly.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	mats
# Host:	romeo.(none)
# Root:	/home/bk/b22583-mysql-5.1-new-rpl

--- 1.416/sql/ha_ndbcluster.cc	2007-03-08 09:06:15 +01:00
+++ 1.417/sql/ha_ndbcluster.cc	2007-03-08 09:06:15 +01:00
@@ -3111,6 +3111,18 @@
 
   // Set null flag(s)
   bzero(buf, table->s->null_bytes);
+
+  /*
+    Set the X bit and the filler bits of the null byte, since they are
+    not touched in the code below.
+
+    The X bit is the LSB in the first byte
+    The filler bits are the MSBs in the last null byte
+  */
+  buf[0]|= 1;
+  if (table->s->null_bytes > 0)
+    buf[table->s->null_bytes - 1]|= 256U - (1U << table->s->last_null_bit_pos);
+
   for ( ; field;
        p_field++, value++, field= *p_field)
   {