bk commit into 5.1 tree (mats:1.2411) BUG#23171

[Mats Kindahl]

Below is the list of changes that have just been committed into a local
5.1 repository of mats. When mats does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-03-05 17:32:48+01:00, mats@romeo.(none) +1 -0
  BUG#23171 (Illegal group log position):
  Improving function comment.

  sql/log_event.h@stripped, 2007-03-05 17:32:45+01:00, mats@romeo.(none) +14 -3
    Comment change.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	mats
# Host:	romeo.(none)
# Root:	/home/bk/b23171-mysql-5.1-new-rpl

--- 1.142/sql/log_event.h	2007-03-05 17:32:57 +01:00
+++ 1.143/sql/log_event.h	2007-03-05 17:32:57 +01:00
@@ -839,10 +839,20 @@
 
 
   /**
-     Advance binary log coordinates.
+     Advance relay log coordinates.
 
-     This function is called to advance the binary log or relay log
-     coordinates to just after the event.
+     This function is called to advance the relay log coordinates to
+     just after the event.  It is essential that both the relay log
+     coordinate and the group log position is updated correctly, since
+     this function is used also for skipping events.
+
+     Normally, each implementation of do_update_pos() shall:
+
+     - Update the event position to refer to the position just after
+       the event.
+
+     - Update the group log position to refer to the position just
+       after the event <em>if the event is last in a group</em>
 
      @param rli Pointer to relay log info structure
 
@@ -852,6 +862,7 @@
                    do_apply_event() function, and not by this one.
    */
   virtual int do_update_pos(RELAY_LOG_INFO *rli);
+
 
   /**
      Decide if this event shall be skipped or not and the reason for