bk commit into 5.0 tree (msvensson:1.2457) BUG#18441

[msvensson]

Below is the list of changes that have just been committed into a local
5.0 repository of msvensson. When msvensson does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-03-05 11:02:40+01:00, msvensson@stripped +1 -0
  Bug#18441 MessageBox function used in server code on windows(part ) 
   - Handle error to create a named pipe in just the same way as
     failure to create the server socket. Log the error and 
     abort startup.

  sql/mysqld.cc@stripped, 2007-03-05 11:02:39+01:00, msvensson@stripped +5 -12
    Don't popup a message box when CreateNamedPipe fails. 

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	msvensson
# Host:	pilot.blaudden
# Root:	/home/msvensson/mysql/bug18441/my50-bug18441

--- 1.601/sql/mysqld.cc	2007-02-28 16:40:01 +01:00
+++ 1.602/sql/mysqld.cc	2007-03-05 11:02:39 +01:00
@@ -1516,18 +1516,11 @@ static void network_init(void)
 				(int) global_system_variables.net_buffer_length,
 				NMPWAIT_USE_DEFAULT_WAIT,
 				&saPipeSecurity)) == INVALID_HANDLE_VALUE)
-      {
-	LPVOID lpMsgBuf;
-	int error=GetLastError();
-	FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER |
-		      FORMAT_MESSAGE_FROM_SYSTEM,
-		      NULL, error, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
-		      (LPTSTR) &lpMsgBuf, 0, NULL );
-	MessageBox(NULL, (LPTSTR) lpMsgBuf, "Error from CreateNamedPipe",
-		    MB_OK|MB_ICONINFORMATION);
-	LocalFree(lpMsgBuf);
-	unireg_abort(1);
-      }
+    {
+      sql_print_error("Can't start server: Failed to create named pipe: %d",
+                      GetLastError());
+      unireg_abort(1);
+    }
   }
 #endif