From: Date: February 23 2007 10:28am
Subject: bk commit into 5.0 tree (msvensson:1.2407) BUG#25197
List-Archive: http://lists.mysql.com/commits/20443
X-Bug: 25197
Message-Id: <200702230928.l1N9Sro5001001@pilot.blaudden>

Below is the list of changes that have just been committed into a local
5.0 repository of msvensson. When msvensson does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-02-23 10:28:50+01:00, msvensson@stripped +3 -0
  Bug#25197 repeat function returns null when using table field directly as count
   - Return empty string also if count is unsigned and value is 0

  mysql-test/r/func_str.result@stripped, 2007-02-23 10:28:49+01:00, msvensson@stripped +14 -0
    Update test result

  mysql-test/t/func_str.test@stripped, 2007-02-23 10:28:49+01:00, msvensson@stripped +22 -0
    Add test case for using an unsigned value as count parameter
    for REPEAT

  sql/item_strfunc.cc@stripped, 2007-02-23 10:28:49+01:00, msvensson@stripped +3 -1
    The repeat function should return the emptystring if
    count is unsigned and equal to zero or
    count is signed and less than or equal to zero

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	msvensson
# Host:	pilot.blaudden
# Root:	/home/msvensson/mysql/bug25197/my50-bug25197

--- 1.293/sql/item_strfunc.cc	2007-01-12 14:40:31 +01:00
+++ 1.294/sql/item_strfunc.cc	2007-02-23 10:28:49 +01:00
@@ -2251,8 +2251,10 @@ String *Item_func_repeat::val_str(String
   if (args[0]->null_value || args[1]->null_value)
     goto err;				// string and/or delim are null
   null_value= 0;
-  if ((count <= 0) && !args[1]->unsigned_flag)	// For nicer SQL code
+
+  if (count == 0 || count < 0 && !args[1]->unsigned_flag)
     return &my_empty_string;
+
   /* Assumes that the maximum length of a String is < INT_MAX32. */
   /* Bounds check on count:  If this is triggered, we will error. */
   if ((ulonglong) count > INT_MAX32)

--- 1.126/mysql-test/r/func_str.result	2007-01-12 15:34:59 +01:00
+++ 1.127/mysql-test/r/func_str.result	2007-02-23 10:28:49 +01:00
@@ -1940,4 +1940,18 @@ abcxx
 select lpad('abc', cast(5 as unsigned integer), 'x');
 lpad('abc', cast(5 as unsigned integer), 'x')
 xxabc
+DROP TABLE IF EXISTS t1;
+CREATE TABLE `t1` (
+`id` varchar(20) NOT NULL,
+`tire` tinyint(3) unsigned NOT NULL,
+PRIMARY KEY (`id`)
+);
+INSERT INTO `t1` (`id`, `tire`) VALUES ('A', 0), ('B', 1),('C', 2);
+SELECT REPEAT( '#', tire ) AS A,
+REPEAT( '#', tire % 999 ) AS B, tire FROM `t1`;
+A	B	tire
+		0
+#	#	1
+##	##	2
+DROP TABLE t1;
 End of 5.0 tests

--- 1.99/mysql-test/t/func_str.test	2007-01-12 14:40:31 +01:00
+++ 1.100/mysql-test/t/func_str.test	2007-02-23 10:28:49 +01:00
@@ -1008,4 +1008,26 @@ select repeat('a', cast(2 as unsigned in
 select rpad('abc', cast(5 as unsigned integer), 'x');
 select lpad('abc', cast(5 as unsigned integer), 'x');
 
+
+#
+# Bug #25197 :repeat function returns null when using table field directly as count
+#
+
+--disable_warnings
+DROP TABLE IF EXISTS t1;
+--enable_warnings
+
+CREATE TABLE `t1` (
+  `id` varchar(20) NOT NULL,
+  `tire` tinyint(3) unsigned NOT NULL,
+  PRIMARY KEY (`id`)
+);
+
+INSERT INTO `t1` (`id`, `tire`) VALUES ('A', 0), ('B', 1),('C', 2);
+
+SELECT REPEAT( '#', tire ) AS A,
+       REPEAT( '#', tire % 999 ) AS B, tire FROM `t1`;
+
+DROP TABLE t1;
+
 --echo End of 5.0 tests