bk commit into 5.0 tree (rafal:1.2394) BUG#25463

[rsomla]

Below is the list of changes that have just been committed into a local
5.0 repository of rafal. When rafal does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-02-04 18:46:48+01:00, rafal@quant.(none) +1 -0
  BUG#25463 (Memory allocation problems in replication slave thread):
  The problem is (most probably) caused by whole server shutting down before a 
  slave thread terminates correctly. Fixing this requires fixing server shutdown
  code which has been done in 5.1 tree. Thus we ignore the issue in 5.0 assuming 
  that it is fixed in 5.1.  

  mysql-test/valgrind.supp@stripped, 2007-02-04 18:46:45+01:00, rafal@quant.(none) +17 -0
    Added a suppresion rule.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	rafal
# Host:	quant.(none)
# Root:	/ext/mysql/bk/mysql-5.0-bug25463

--- 1.7/mysql-test/valgrind.supp	2007-02-04 18:46:55 +01:00
+++ 1.8/mysql-test/valgrind.supp	2007-02-04 18:46:55 +01:00
@@ -346,3 +346,20 @@
    fun:_ZN19TransporterRegistry11performSendEv
    fun:_ZN19TransporterRegistry14forceSendCheckEi
 }
+
+#
+# BUG#25463: Probable cause - slave thread doesn't have time to terminate properly
+# because rest of the server shuts down before that. The server shutdown code has
+# been fixed in 5.1 and there this leak should not happen. Suppression has been 
+# approved by Monty.
+#
+# Important: do not propagate this rule to 5.1 tree!
+#
+
+{
+   Slave thread shutdown (BUG#25463)
+   Memcheck:Leak
+   fun:calloc
+   fun:my_thread_init
+   fun:handle_slave_io
+}