From: Date: February 7 2007 11:22pm
Subject: bk commit into 5.0 tree (antony:1.2405) BUG#12204
List-Archive: http://lists.mysql.com/commits/19522
X-Bug: 12204
Message-Id: <20070207222227.13CACB99AED@ppcg5.local>

Below is the list of changes that have just been committed into a local
5.0 repository of antony. When antony does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-02-07 14:22:19-08:00, antony@stripped +3 -0
  Bug#12204
    "CONNECTION is a reserved keyword"
    Allow connection to be used as an ordinary identifier
    Tests included.

  mysql-test/r/keywords.result@stripped, 2007-02-07 14:22:16-08:00, antony@stripped +13 -0
    test that CONNECTION may be used as ordinary identifier
    test that CONNECTION may be used in stored procedure.

  mysql-test/t/keywords.test@stripped, 2007-02-07 14:22:16-08:00, antony@stripped +22 -0
    test that CONNECTION may be used as ordinary identifier
    test that CONNECTION may be used in stored procedure.

  sql/sql_yacc.yy@stripped, 2007-02-07 14:22:17-08:00, antony@stripped +1 -0
    Set CONNECTION as an unreserved keyword

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	antony
# Host:	ppcg5.local
# Root:	/Users/antony/Work/p3-bug12204.4

--- 1.504/sql/sql_yacc.yy	2007-02-07 14:22:26 -08:00
+++ 1.505/sql/sql_yacc.yy	2007-02-07 14:22:26 -08:00
@@ -7926,6 +7926,7 @@ keyword_sp:
 	| COMPACT_SYM		{}
 	| COMPRESSED_SYM	{}
 	| CONCURRENT		{}
+	| CONNECTION_SYM	{}
 	| CONSISTENT_SYM	{}
 	| CUBE_SYM		{}
 	| DATA_SYM		{}

--- 1.7/mysql-test/r/keywords.result	2007-02-07 14:22:26 -08:00
+++ 1.8/mysql-test/r/keywords.result	2007-02-07 14:22:26 -08:00
@@ -16,3 +16,16 @@ select events.binlog from events;
 binlog
 1
 drop table events;
+create table t1 (connection int, b int);
+create procedure p1()
+begin
+declare connection int;
+select max(t1.connection) into connection from t1;
+select concat("max=",connection) 'p1';
+end|
+insert into t1 (connection) values (1);
+call p1();
+p1
+max=1
+drop procedure p1;
+drop table t1;

--- 1.7/mysql-test/t/keywords.test	2007-02-07 14:22:26 -08:00
+++ 1.8/mysql-test/t/keywords.test	2007-02-07 14:22:26 -08:00
@@ -19,3 +19,25 @@ select events.binlog from events;
 drop table events;
 
 # End of 4.1 tests
+
+
+#
+# Bug#12204 - CONNECTION should not be a reserved word
+#
+
+create table t1 (connection int, b int);
+delimiter |;
+create procedure p1()
+begin
+  declare connection int;
+  select max(t1.connection) into connection from t1;
+  select concat("max=",connection) 'p1';
+end|
+delimiter ;|
+insert into t1 (connection) values (1);
+call p1();
+drop procedure p1;
+drop table t1;
+
+
+# End of 5.0 tests