List:Commits« Previous MessageNext Message »
From:tomas Date:January 31 2007 7:01am
Subject:bk commit into 5.1 tree (tomas:1.2415) BUG#25239
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of tomas. When tomas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2415 07/01/31 13:01:03 tomas@stripped +1 -0
  Bug#25239	Out of memory problem can cause crash in SUMA

  storage/ndb/src/kernel/blocks/suma/Suma.cpp
    1.54 07/01/31 13:00:54 tomas@stripped +3 -4
    return RNIL instead of ndbrequire if memory allocation fails

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	tomas
# Host:	poseidon.mysql.com
# Root:	/home/tomas/mysql-5.1-new-ndb

--- 1.53/storage/ndb/src/kernel/blocks/suma/Suma.cpp	2007-01-22 23:57:09 +07:00
+++ 1.54/storage/ndb/src/kernel/blocks/suma/Suma.cpp	2007-01-31 13:00:54 +07:00
@@ -4668,9 +4668,7 @@
   m_out_of_buffer_gci = m_last_complete_gci - 1;
   infoEvent("Out of event buffer: nodefailure will cause event failures");
 
-  signal->theData[0] = SumaContinueB::OUT_OF_BUFFER_RELEASE;
-  signal->theData[1] = 0;
-  sendSignal(SUMA_REF, GSN_CONTINUEB, signal, 2, JBB);
+  out_of_buffer_release(signal, 0);
 }
 
 void
@@ -4738,7 +4736,8 @@
 
   Uint32 count;
   m_tup->allocConsPages(16, count, ref);
-  ndbrequire(count > 0);
+  if (count == 0)
+    return RNIL;
 
   ndbout_c("alloc_chunk(%d %d) - ", ref, count);
 
Thread
bk commit into 5.1 tree (tomas:1.2415) BUG#25239tomas31 Jan