From: Date: January 24 2007 6:21pm
Subject: bk commit into 5.1 tree (jonas:1.2094) BUG#24949
List-Archive: http://lists.mysql.com/commits/18732
X-Bug: 24949
Message-Id: <20070124172113.265436A2831@perch.ndb.mysql.com>

Below is the list of changes that have just been committed into a local
5.1 repository of jonas. When jonas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-01-24 18:21:09+01:00, jonas@stripped +2 -0
  ndb - bug#24949
    Make sure not to poll to long in case of hb-failure of last db-node
    (recommit mysql-5.1-wl2325-5.0)

  storage/ndb/src/ndbapi/Ndbif.cpp@stripped, 2007-01-24 18:21:08+01:00, jonas@stripped +2 -2
    Make sure not to poll too long

  storage/ndb/src/ndbapi/TransporterFacade.cpp@stripped, 2007-01-24 18:21:08+01:00, jonas@stripped +3 -5
    Make sure not to poll too long

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	jonas
# Host:	perch.ndb.mysql.com
# Root:	/home/jonas/src/drop5

--- 1.37/storage/ndb/src/ndbapi/Ndbif.cpp	2007-01-24 18:21:13 +01:00
+++ 1.38/storage/ndb/src/ndbapi/Ndbif.cpp	2007-01-24 18:21:13 +01:00
@@ -1242,9 +1242,9 @@
   NDB_TICKS currTime = NdbTick_CurrentMillisecond();
   NDB_TICKS maxTime = currTime + (NDB_TICKS)waitTime;
   theMinNoOfEventsToWakeUp = noOfEventsToWaitFor;
+  const int maxsleep = aMilliSecondsToWait > 10 ? 10 : aMilliSecondsToWait;
   do {
-    if (waitTime < 1000) waitTime = 1000;
-    poll_guard->wait_for_input(waitTime);
+    poll_guard->wait_for_input(maxsleep);
     if (theNoOfCompletedTransactions >= (Uint32)noOfEventsToWaitFor) {
       break;
     }//if

--- 1.48/storage/ndb/src/ndbapi/TransporterFacade.cpp	2007-01-24 18:21:13 +01:00
+++ 1.49/storage/ndb/src/ndbapi/TransporterFacade.cpp	2007-01-24 18:21:13 +01:00
@@ -1370,15 +1370,13 @@
     m_tp->forceSend(m_block_no);
   else
     m_tp->checkForceSend(m_block_no);
-  if (wait_time == -1) //Means wait forever
-    response_time= WAITFOR_RESPONSE_TIMEOUT;
-  else
-    response_time= wait_time;
+
   NDB_TICKS curr_time = NdbTick_CurrentMillisecond();
   NDB_TICKS max_time = curr_time + (NDB_TICKS)wait_time;
+  const int maxsleep = (wait_time == -1 || wait_time > 10) ? 10 : wait_time;
   do
   {
-    wait_for_input(response_time);
+    wait_for_input(maxsleep);
     Uint32 state= m_waiter->get_state();
     if (state == NO_WAIT)
     {