List:Commits« Previous MessageNext Message »
From:'Hartmut Holzgraefe' Date:January 23 2007 1:25pm
Subject:bk commit into 5.0 tree (hartmut:1.2383)
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of hartmut. When hartmut does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-01-23 14:25:05+01:00, hartmut@stripped +1 -0
  Merge hholzgraefe@stripped:/home/bk/mysql-5.0
  into  mysql.com:/home/hartmut/projects/mysql/dev/5.0
  MERGE: 1.2341.40.1

  libmysql/libmysql.c@stripped, 2007-01-23 14:25:00+01:00, hartmut@stripped +0 -0
    Auto merged
    MERGE: 1.251.1.1

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	hartmut
# Host:	linux.site
# Root:	/home/hartmut/projects/mysql/dev/5.0/RESYNC

--- 1.252/libmysql/libmysql.c	2007-01-23 14:25:15 +01:00
+++ 1.253/libmysql/libmysql.c	2007-01-23 14:25:15 +01:00
@@ -2042,6 +2042,13 @@
     DBUG_RETURN(1);
   }
 
+  /*
+    Reset the last error in any case: that would clear the statement
+    if the previous prepare failed.
+  */
+  stmt->last_errno= 0;
+  stmt->last_error[0]= '\0';
+
   if ((int) stmt->state > (int) MYSQL_STMT_INIT_DONE)
   {
     /* This is second prepare with another statement */
@@ -2055,23 +2062,24 @@
     */
     stmt->bind_param_done= stmt->bind_result_done= FALSE;
     stmt->param_count= stmt->field_count= 0;
-    stmt->last_errno= 0;
-    stmt->last_error[0]= '\0';
     free_root(&stmt->mem_root, MYF(MY_KEEP_PREALLOC));
 
     int4store(buff, stmt->stmt_id);
+
     /*
+      Close statement in server
+
       If there was a 'use' result from another statement, or from
       mysql_use_result it won't be freed in mysql_stmt_free_result and
       we should get 'Commands out of sync' here.
     */
+    stmt->state= MYSQL_STMT_INIT_DONE;
     if (stmt_command(mysql, COM_STMT_CLOSE, buff, 4, stmt))
     {
       set_stmt_errmsg(stmt, mysql->net.last_error, mysql->net.last_errno,
                       mysql->net.sqlstate);
       DBUG_RETURN(1);
     }
-    stmt->state= MYSQL_STMT_INIT_DONE;
   }
 
   if (stmt_command(mysql, COM_STMT_PREPARE, query, length, stmt))
Thread
bk commit into 5.0 tree (hartmut:1.2383)'Hartmut Holzgraefe'23 Jan