From: Date: January 17 2007 10:06am
Subject: bk commit into 5.0 tree (tulin:1.2383) BUG#25668
List-Archive: http://lists.mysql.com/commits/18233
X-Bug: 25668
Message-Id: <200701170906.l0H96uar001792@production.mysql.com>

Below is the list of changes that have just been committed into a local
5.0 repository of mysqldev. When mysqldev does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-01-17 10:06:50+01:00, tulin@stripped +1 -0
  ha_ndbcluster.cc:
      Bug #25668    ndb: mysqld may core if cluster disconnected
      -- pTrans may be NULL, remove not needed usage of handler::ndb_err

  sql/ha_ndbcluster.cc@stripped, 2007-01-17 10:06:00+01:00, tulin@stripped +9 -16
      Bug #25668    ndb: mysqld may core if cluster disconnected
      -- pTrans may be NULL, remove not needed usage of handler::ndb_err

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	tulin
# Host:	production.mysql.com
# Root:	/data0/mysqldev/users/tomas/mysql-5.0-release

--- 1.292/sql/ha_ndbcluster.cc	2007-01-17 10:06:56 +01:00
+++ 1.293/sql/ha_ndbcluster.cc	2007-01-17 10:06:56 +01:00
@@ -6109,23 +6109,7 @@
 
     DBUG_RETURN(0);
 retry:
-    if(report_error)
-    {
-      if (file)
-      {
-        reterr= file->ndb_err(pTrans);
-      }
-      else
-      {
-        const NdbError& tmp= error;
-        ERR_PRINT(tmp);
-        reterr= ndb_to_mysql_error(&tmp);
-      }
-    }
-    else
-      reterr= error.code;
 
-    if (pTrans)
     {
       ndb->closeTransaction(pTrans);
       pTrans= NULL;
@@ -6135,6 +6119,15 @@
       my_sleep(retry_sleep);
       continue;
     }
+    if(report_error)
+    {
+      const NdbError& tmp= error;
+      ERR_PRINT(tmp);
+      reterr= ndb_to_mysql_error(&tmp);
+    }
+    else
+      reterr= error.code;
+
     break;
   } while(1);
   DBUG_PRINT("exit", ("failed, reterr: %u, NdbError %u(%s)", reterr,