From: Date: January 5 2007 12:00pm
Subject: bk commit into 5.0 tree (gkodinov:1.2366) BUG#15881
List-Archive: http://lists.mysql.com/commits/17656
X-Bug: 15881
Message-Id: <20070105110049.35006AF6F4F@macbook.gmz>

Below is the list of changes that have just been committed into a local
5.0 repository of kgeorge. When kgeorge does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-01-05 13:00:32+02:00, gkodinov@stripped +3 -0
  Bug #15881: cast problems
    The optimizer removes expressions from GROUP BY/DISTINCT
    if they happen to participate in a <expression> = <const>
    predicates of the WHERE clause (the idea being that if
    it's always equal to a constant it can't have multiple 
    values).
    However for predicates where the expression and the 
    constant item are of different result type this is not
    valid (e.g. a string column compared to 0).
    Fixed by additional check of the result types of the 
    expression and the constant and if they differ the 
    expression don't get removed from the group by list.

  mysql-test/r/distinct.result@stripped, 2007-01-05 13:00:24+02:00, gkodinov@stripped +37 -0
    Bug #15881: cast problems
      - test case

  mysql-test/t/distinct.test@stripped, 2007-01-05 13:00:25+02:00, gkodinov@stripped +21 -0
    Bug #15881: cast problems
      - test case

  sql/sql_select.cc@stripped, 2007-01-05 13:00:26+02:00, gkodinov@stripped +36 -2
    Bug #15881: cast problems
      - can't use <expr>=<const> to remove GROUP BY/DISTINCT cols
        if they're not of the same type.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	gkodinov
# Host:	macbook.gmz
# Root:	/Users/kgeorge/mysql/work/B15881-5.0-opt

--- 1.480/sql/sql_select.cc	2006-12-30 22:02:07 +02:00
+++ 1.481/sql/sql_select.cc	2007-01-05 13:00:26 +02:00
@@ -8432,6 +8432,40 @@ remove_eq_conds(THD *thd, COND *cond, It
   return cond;					// Point at next and level
 }
 
+/* 
+  Check if comparison args can be used for removal of GROUP BY/DISTINCT
+  
+  SYNOPSIS
+    is_const_with_same_type()
+      l          the left comparison argument
+      r          the right comparison argument
+  
+  DESCRIPTION    
+    Checks if the args of equal comparison can be used to take 
+    away DISTINCT/GROUP BY : generally <expr> == <const>.
+    Arguments must be of the same type because e.g. 
+    <string_field> = <int_const> may match more than 1 row. 
+    We must take into consideration and the optimization done for various 
+    string constants when compared to dates etc (see Item_int_with_ref)
+  
+  RETURN VALUE  
+    TRUE    can be used
+    FALSE   cannot be used
+*/
+static bool
+is_const_with_same_type(Item *l, Item *r)
+{
+  return r->const_item() &&
+    (r->result_type() == l->result_type() ||
+     (((l->type() == Item::FIELD_ITEM && 
+        ((Item_field *)l)->field->can_be_compared_as_longlong()) ||
+       (l->type() == Item::FUNC_ITEM &&
+        ((Item_func *)l)->result_as_longlong())) &&
+      r->result_type() == INT_RESULT))
+    /*&& (l->result_type() != STRING_RESULT ||
+        l->collation.collation == r->collation.collation)*/;
+}
+
 /*
   Return 1 if the item is a const value in all the WHERE clause
 */
@@ -8468,7 +8502,7 @@ const_expression_in_where(COND *cond, It
     Item *right_item= ((Item_func*) cond)->arguments()[1];
     if (left_item->eq(comp_item,1))
     {
-      if (right_item->const_item())
+      if (is_const_with_same_type (left_item, right_item))
       {
 	if (*const_item)
 	  return right_item->eq(*const_item, 1);
@@ -8478,7 +8512,7 @@ const_expression_in_where(COND *cond, It
     }
     else if (right_item->eq(comp_item,1))
     {
-      if (left_item->const_item())
+      if (is_const_with_same_type (right_item, left_item))
       {
 	if (*const_item)
 	  return left_item->eq(*const_item, 1);

--- 1.49/mysql-test/r/distinct.result	2006-11-30 20:09:45 +02:00
+++ 1.50/mysql-test/r/distinct.result	2007-01-05 13:00:24 +02:00
@@ -607,3 +607,40 @@ id	select_type	table	type	possible_keys	
 SELECT DISTINCT a,a FROM t1 WHERE b < 12 ORDER BY a;
 a	a
 DROP TABLE t1;
+CREATE TABLE t1 (a CHAR(1));
+INSERT INTO t1 VALUES('A'), (0);
+SELECT a FROM t1 WHERE a=0;
+a
+A
+0
+Warnings:
+Warning	1292	Truncated incorrect DOUBLE value: 'A'
+SELECT DISTINCT a FROM t1 WHERE a=0;
+a
+A
+0
+Warnings:
+Warning	1292	Truncated incorrect DOUBLE value: 'A'
+DROP TABLE t1;
+CREATE TABLE t1 (a DATE);
+INSERT INTO t1 VALUES ('1972-07-29'), ('1972-02-06');
+EXPLAIN SELECT (SELECT DISTINCT a FROM t1 WHERE a = '2002-08-03');
+id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra
+1	PRIMARY	NULL	NULL	NULL	NULL	NULL	NULL	NULL	No tables used
+2	SUBQUERY	t1	ALL	NULL	NULL	NULL	NULL	2	Using where
+EXPLAIN SELECT (SELECT DISTINCT ADDDATE(a,1) FROM t1
+WHERE ADDDATE(a,1) = '2002-08-03');
+id	select_type	table	type	possible_keys	key	key_len	ref	rows	Extra
+1	PRIMARY	NULL	NULL	NULL	NULL	NULL	NULL	NULL	No tables used
+2	SUBQUERY	t1	ALL	NULL	NULL	NULL	NULL	2	Using where
+CREATE TABLE t2 (a CHAR(5) CHARACTER SET latin1 COLLATE latin1_general_ci);
+INSERT INTO t2 VALUES (0xf6);
+INSERT INTO t2 VALUES ('oe');
+SELECT COUNT(*) FROM (SELECT DISTINCT a FROM t2) dt;
+COUNT(*)
+2
+SELECT COUNT(*) FROM 
+(SELECT DISTINCT a FROM t2 WHERE a='oe' COLLATE latin1_german2_ci) dt;
+COUNT(*)
+1
+DROP TABLE t1, t2;

--- 1.28/mysql-test/t/distinct.test	2007-01-02 15:50:21 +02:00
+++ 1.29/mysql-test/t/distinct.test	2007-01-05 13:00:25 +02:00
@@ -504,3 +504,24 @@ DROP TABLE t1;
 #DROP TABLE t1;
 #DROP TABLE t2;
 
+#
+# Bug #15881: cast problems
+#
+CREATE TABLE t1 (a CHAR(1)); INSERT INTO t1 VALUES('A'), (0);
+SELECT a FROM t1 WHERE a=0;
+SELECT DISTINCT a FROM t1 WHERE a=0;
+DROP TABLE t1;
+CREATE TABLE t1 (a DATE);
+INSERT INTO t1 VALUES ('1972-07-29'), ('1972-02-06');
+EXPLAIN SELECT (SELECT DISTINCT a FROM t1 WHERE a = '2002-08-03');
+EXPLAIN SELECT (SELECT DISTINCT ADDDATE(a,1) FROM t1
+                WHERE ADDDATE(a,1) = '2002-08-03');
+CREATE TABLE t2 (a CHAR(5) CHARACTER SET latin1 COLLATE latin1_general_ci);
+INSERT INTO t2 VALUES (0xf6);
+INSERT INTO t2 VALUES ('oe');
+
+SELECT COUNT(*) FROM (SELECT DISTINCT a FROM t2) dt;
+SELECT COUNT(*) FROM 
+  (SELECT DISTINCT a FROM t2 WHERE a='oe' COLLATE latin1_german2_ci) dt;
+
+DROP TABLE t1, t2;