List:Commits« Previous MessageNext Message »
From:jimw Date:December 28 2006 10:47pm
Subject:[svn:DBD-mysql] r8486 - in DBD-mysql/trunk: . lib/DBD t
View as plain text  
Author: jimw
Date: Thu Dec 28 14:47:38 2006
New Revision: 8486

Modified:
   DBD-mysql/trunk/ChangeLog
   DBD-mysql/trunk/lib/DBD/mysql.pm
   DBD-mysql/trunk/t/40listfields.t

Log:
Remove bogus check for wildcards in the table name given to the column_info
method. (Bug #22005, reported by Philip Stoev)


Modified: DBD-mysql/trunk/ChangeLog
==============================================================================
--- DBD-mysql/trunk/ChangeLog	(original)
+++ DBD-mysql/trunk/ChangeLog	Thu Dec 28 14:47:38 2006
@@ -1,4 +1,6 @@
 <unreleased> Jim Winstead <jimw@stripped> (4.01)
+* Fix handling of table names with characters that did not match /\w/ in
+  the column_info method. (Bug #22005, reported by Philip Stoev)
 * Fix handling of negative integers bound to a column marked as SQL_INTEGER.
   [rt.cpan.org #18976], patch from Mike Schilli.
 * Add support for the primary_key_info method. [rt.cpan.org #8541]

Modified: DBD-mysql/trunk/lib/DBD/mysql.pm
==============================================================================
--- DBD-mysql/trunk/lib/DBD/mysql.pm	(original)
+++ DBD-mysql/trunk/lib/DBD/mysql.pm	Thu Dec 28 14:47:38 2006
@@ -296,8 +296,6 @@
 
 sub column_info {
     my ($dbh, $catalog, $schema, $table, $column) = @_;
-    return $dbh->set_err(1, "column_info doesn't support table wildcard")
-	if $table !~ /^\w+$/;
     return $dbh->set_err(1, "column_info doesn't support column selection")
 	if $column ne "%";
 

Modified: DBD-mysql/trunk/t/40listfields.t
==============================================================================
--- DBD-mysql/trunk/t/40listfields.t	(original)
+++ DBD-mysql/trunk/t/40listfields.t	Thu Dec 28 14:47:38 2006
@@ -58,10 +58,10 @@
 	or ServerError();
 
     #
-    #   Find a possible new table name
-    #
-    Test($state or $table = FindNewTable($dbh))
-	   or DbiError($dbh->err, $dbh->errstr);
+    # We use a hardcoded special table name to test for a regression of
+    # http://bugs.mysql.com/22005
+    #  
+    $table= 't1$special';
 
     #
     #   Create a new table
Thread
[svn:DBD-mysql] r8486 - in DBD-mysql/trunk: . lib/DBD tjimw28 Dec