bk commit into 4.1 tree (iggy:1.2556) BUG#20836

[Ignacio Galarza]

Below is the list of changes that have just been committed into a local
4.1 repository of iggy. When iggy does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-12-05 09:29:32-05:00, iggy@stripped +1 -0
  Bug#20836 Selecting into variables results in wrong results being returned
  - Comment Cleanup.

  sql/sql_class.cc@stripped, 2006-12-05 09:29:30-05:00, iggy@stripped +0 -8
    Removed misleading comment.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	iggy
# Host:	rolltop.ignatz42.dyndns.org
# Root:	/mnt/storeage/bug20836/my41-bug20836

--- 1.212/sql/sql_class.cc	2006-12-05 09:29:36 -05:00
+++ 1.213/sql/sql_class.cc	2006-12-05 09:29:36 -05:00
@@ -1746,14 +1746,6 @@ bool select_dumpvar::send_data(List<Item
   while ((ls= var_li++) && (item= it++))
   {
     Item_func_set_user_var *suv= new Item_func_set_user_var(*ls, item);
-
-    /*
-      Item_func_set_user_var can't substitute something else on its
-      place => NULL may be passed as last argument (reference on
-      item) Item_func_set_user_var can't be fixed after creation, so
-      we do not check var->fixed
-    */
-
     suv->fix_fields(thd, (TABLE_LIST *) thd->lex->select_lex.table_list.first,
             0);
     suv->check();