List:Commits« Previous MessageNext Message »
From:monty Date:November 30 2006 7:48pm
Subject:bk commit into 5.0 tree (monty:1.2328)
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of monty. When monty does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-11-30 21:48:31+02:00, monty@stripped +22 -0
  Fixed compiler warnings

  client/mysqldump.c@stripped, 2006-11-30 21:48:29+02:00, monty@stripped +1 -1
    Fixed compiler warnings

  client/mysqltest.c@stripped, 2006-11-30 21:48:29+02:00, monty@stripped +9 -8
    Fixed compiler warnings

  cmd-line-utils/readline/bind.c@stripped, 2006-11-30 21:48:29+02:00, monty@stripped +3 -1
    Fixed compiler warnings

  cmd-line-utils/readline/histfile.c@stripped, 2006-11-30 21:48:29+02:00, monty@stripped +2 -1
    Fixed compiler warnings

  extra/yassl/taocrypt/include/algebra.hpp@stripped, 2006-11-30 21:48:29+02:00, monty@stripped +1 -1
    Fixed compiler warnings

  heap/hp_write.c@stripped, 2006-11-30 21:48:29+02:00, monty@stripped +1 -1
    Fixed compiler warnings

  innobase/os/os0file.c@stripped, 2006-11-30 21:48:29+02:00, monty@stripped +1 -1
    Fixed compiler warnings

  libmysql/libmysql.c@stripped, 2006-11-30 21:48:29+02:00, monty@stripped +7 -3
    Call my_end()/my_thread_end last.
    my_end() calls free_charsets(), which allowed me to move the call

  myisam/myisampack.c@stripped, 2006-11-30 21:48:29+02:00, monty@stripped +7 -7
    Fixed compiler warnings

  myisammrg/myrg_rkey.c@stripped, 2006-11-30 21:48:29+02:00, monty@stripped +1 -1
    Fixed compiler warnings

  mysys/my_thr_init.c@stripped, 2006-11-30 21:48:29+02:00, monty@stripped +32 -8
    More comments
    Don't assert if my_thread_end() is called twice (common case)

  ndb/src/mgmapi/mgmapi.cpp@stripped, 2006-11-30 21:48:29+02:00, monty@stripped +3 -3
    Fixed compiler warnings

  ndb/src/ndbapi/Ndb.cpp@stripped, 2006-11-30 21:48:29+02:00, monty@stripped +12 -11
    Fixed compiler warnings

  ndb/src/ndbapi/NdbScanOperation.cpp@stripped, 2006-11-30 21:48:30+02:00, monty@stripped +3 -3
    Fixed compiler warnings

  ndb/src/ndbapi/NdbTransaction.cpp@stripped, 2006-11-30 21:48:30+02:00, monty@stripped +2 -1
    Fixed compiler warnings

  ndb/src/ndbapi/Ndblist.cpp@stripped, 2006-11-30 21:48:30+02:00, monty@stripped +1 -1
    Fixed compiler warnings

  sql/ha_archive.cc@stripped, 2006-11-30 21:48:30+02:00, monty@stripped +7 -6
    Fixed compiler warnings

  sql/ha_ndbcluster.cc@stripped, 2006-11-30 21:48:30+02:00, monty@stripped +2 -2
    Fixed compiler warnings

  sql/mysqld.cc@stripped, 2006-11-30 21:48:30+02:00, monty@stripped +1 -1
    Fixed compiler warnings

  sql/sql_cache.cc@stripped, 2006-11-30 21:48:30+02:00, monty@stripped +19 -19
    Fixed compiler warnings
    Fixed DBUG_PRINT strings to be consistent with 5.1

  sql/tztime.cc@stripped, 2006-11-30 21:48:30+02:00, monty@stripped +5 -5
    Fixed compiler warnings

  sql/uniques.cc@stripped, 2006-11-30 21:48:30+02:00, monty@stripped +2 -2
    Fixed compiler warnings

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	monty
# Host:	narttu.mysql.fi
# Root:	/home/my/mysql-5.0

--- 1.251/client/mysqldump.c	2006-11-30 18:24:52 +02:00
+++ 1.252/client/mysqldump.c	2006-11-30 21:48:29 +02:00
@@ -1419,7 +1419,7 @@
             routine body of other routines that are not the creator of!
           */
           DBUG_PRINT("info",("length of body for %s row[2] '%s' is %d",
-                             routine_name, row[2], strlen(row[2])));
+                             routine_name, row[2], (int) strlen(row[2])));
           if (strlen(row[2]))
           {
             char *query_str= NULL;

--- 1.24/heap/hp_write.c	2006-11-20 22:41:38 +02:00
+++ 1.25/heap/hp_write.c	2006-11-30 21:48:29 +02:00
@@ -68,7 +68,7 @@
   DBUG_RETURN(0);
 
 err:
-  DBUG_PRINT("info",("Duplicate key: %d", keydef - share->keydef));
+  DBUG_PRINT("info",("Duplicate key: %d", (int) (keydef - share->keydef)));
   info->errkey= keydef - share->keydef;
   if (keydef->algorithm == HA_KEY_ALG_BTREE)
   {

--- 1.250/libmysql/libmysql.c	2006-11-27 17:25:37 +02:00
+++ 1.251/libmysql/libmysql.c	2006-11-30 21:48:29 +02:00
@@ -175,6 +175,9 @@
 #ifdef EMBEDDED_LIBRARY
   end_embedded_server();
 #endif
+  finish_client_errs();
+  vio_end();
+
   /* If library called my_init(), free memory allocated by it */
   if (!org_my_init_done)
   {
@@ -185,10 +188,11 @@
 #endif
   }
   else
+  {
+    free_charsets();
     mysql_thread_end();
-  finish_client_errs();
-  free_charsets();
-  vio_end();
+  }
+
   mysql_client_init= org_my_init_done= 0;
 #ifdef EMBEDDED_SERVER
   if (stderror_file)

--- 1.54/myisam/myisampack.c	2006-11-30 18:24:52 +02:00
+++ 1.55/myisam/myisampack.c	2006-11-30 21:48:29 +02:00
@@ -1105,18 +1105,18 @@
     my_off_t  total_count;
     char      llbuf[32];
 
-    DBUG_PRINT("info", ("column: %3u", count - huff_counts + 1));
+    DBUG_PRINT("info", ("column: %3u", (uint) (count - huff_counts + 1)));
     if (verbose >= 2)
-      VOID(printf("column: %3u\n", count - huff_counts + 1));
+      VOID(printf("column: %3u\n", (uint) (count - huff_counts + 1)));
     if (count->tree_buff)
     {
       DBUG_PRINT("info", ("number of distinct values: %u",
-                          (count->tree_pos - count->tree_buff) /
-                          count->field_length));
+                          (uint) ((count->tree_pos - count->tree_buff) /
+                                  count->field_length)));
       if (verbose >= 2)
         VOID(printf("number of distinct values: %u\n",
-                    (count->tree_pos - count->tree_buff) /
-                    count->field_length));
+                    (uint) ((count->tree_pos - count->tree_buff) /
+                            count->field_length)));
     }
     total_count= 0;
     for (idx= 0; idx < 256; idx++)
@@ -2280,7 +2280,7 @@
         {
           VOID(fflush(stdout));
           VOID(fprintf(stderr, "error: Huffman code too long: %u/%u\n",
-                       bits, 8 * sizeof(code)));
+                       bits, (uint) (8 * sizeof(code))));
           errors++;
           break;
         }

--- 1.33/mysys/my_thr_init.c	2006-11-30 18:24:52 +02:00
+++ 1.34/mysys/my_thr_init.c	2006-11-30 21:48:29 +02:00
@@ -98,7 +98,7 @@
   pthread_mutex_init(&THR_LOCK_net,MY_MUTEX_INIT_FAST);
   pthread_mutex_init(&THR_LOCK_charset,MY_MUTEX_INIT_FAST);
   pthread_mutex_init(&THR_LOCK_threads,MY_MUTEX_INIT_FAST);
-  pthread_cond_init (&THR_COND_threads, NULL);
+  pthread_cond_init(&THR_COND_threads, NULL);
 #if defined( __WIN__) || defined(OS2)
   win_pthread_init();
 #endif
@@ -131,7 +131,8 @@
     if (error == ETIMEDOUT || error == ETIME)
     {
       if (THR_thread_count)
-        fprintf(stderr,"Error in my_thread_global_end(): %d threads didn't exit\n",
+        fprintf(stderr,
+                "Error in my_thread_global_end(): %d threads didn't exit\n",
                 THR_thread_count);
       all_threads_killed= 0;
       break;
@@ -170,10 +171,23 @@
 static long thread_id=0;
 
 /*
-  We can't use mutex_locks here if we are using windows as
-  we may have compiled the program with SAFE_MUTEX, in which
-  case the checking of mutex_locks will not work until
-  the pthread_self thread specific variable is initialized.
+  Allocate thread specific memory for the thread, used by mysys and dbug
+
+  SYNOPSIS
+    my_thread_init()
+
+  NOTES
+    We can't use mutex_locks here if we are using windows as
+    we may have compiled the program with SAFE_MUTEX, in which
+    case the checking of mutex_locks will not work until
+    the pthread_self thread specific variable is initialized.
+
+   This function may called multiple times for a thread, for example
+   if one uses my_init() followed by mysql_server_init().
+
+  RETURN
+    0  ok
+    1  Fatal error; mysys/dbug functions can't be used
 */
 
 my_bool my_thread_init(void)
@@ -225,11 +239,22 @@
 }
 
 
+/*
+  Deallocate memory used by the thread for book-keeping
+
+  SYNOPSIS
+    my_thread_end()
+
+  NOTE
+    This may be called multiple times for a thread.
+    This happens for example when one calls 'mysql_server_init()'
+    mysql_server_end() and then ends with a mysql_end().
+*/
+
 void my_thread_end(void)
 {
   struct st_my_thread_var *tmp;
   tmp= my_pthread_getspecific(struct st_my_thread_var*,THR_KEY_mysys);
-  DBUG_ASSERT(tmp);
 
 #ifdef EXTRA_DEBUG_THREADS
   fprintf(stderr,"my_thread_end(): tmp: 0x%lx  thread_id=%ld\n",
@@ -272,7 +297,6 @@
 #if (!defined(__WIN__) && !defined(OS2)) || defined(USE_TLS)
   pthread_setspecific(THR_KEY_mysys,0);
 #endif
-
 }
 
 struct st_my_thread_var *_my_thread_var(void)

--- 1.15/cmd-line-utils/readline/bind.c	2006-11-20 22:41:36 +02:00
+++ 1.16/cmd-line-utils/readline/bind.c	2006-11-30 21:48:29 +02:00
@@ -337,6 +337,7 @@
   KEYMAP_ENTRY k;
 
   k.function = 0;
+  k.type= 0;
 
   /* If no keys to bind to, exit right away. */
   if (!keyseq || !*keyseq)
@@ -735,7 +736,8 @@
   file_size = (size_t)finfo.st_size;
 
   /* check for overflow on very large files */
-  if (file_size != finfo.st_size || file_size + 1 < file_size)
+  if ((long long) file_size != (long long) finfo.st_size ||
+      file_size + 1 < file_size)
     {
       if (file >= 0)
 	close (file);

--- 1.9/cmd-line-utils/readline/histfile.c	2005-07-19 04:00:15 +03:00
+++ 1.10/cmd-line-utils/readline/histfile.c	2006-11-30 21:48:29 +02:00
@@ -184,7 +184,8 @@
   file_size = (size_t)finfo.st_size;
 
   /* check for overflow on very large files */
-  if (file_size != finfo.st_size || file_size + 1 < file_size)
+  if ((long long) file_size != (long long) finfo.st_size ||
+      file_size + 1 < file_size)
     {
       errno = overflow_errno;
       goto error_and_exit;

--- 1.580/sql/mysqld.cc	2006-11-28 00:47:19 +02:00
+++ 1.581/sql/mysqld.cc	2006-11-30 21:48:30 +02:00
@@ -1538,7 +1538,7 @@
     if (strlen(mysqld_unix_port) > (sizeof(UNIXaddr.sun_path) - 1))
     {
       sql_print_error("The socket file path is too long (> %u): %s",
-                      sizeof(UNIXaddr.sun_path) - 1, mysqld_unix_port);
+                      (uint) sizeof(UNIXaddr.sun_path) - 1, mysqld_unix_port);
       unireg_abort(1);
     }
     if ((unix_sock= socket(AF_UNIX, SOCK_STREAM, 0)) < 0)

--- 1.94/sql/sql_cache.cc	2006-11-20 22:41:53 +02:00
+++ 1.95/sql/sql_cache.cc	2006-11-30 21:48:30 +02:00
@@ -902,7 +902,7 @@
     if (thd->db_length)
     {
       memcpy(thd->query+thd->query_length+1, thd->db, thd->db_length);
-      DBUG_PRINT("qcache", ("database : %s length %u",
+      DBUG_PRINT("qcache", ("database: %s  length: %u",
 			    thd->db, thd->db_length)); 
     }
     else
@@ -1048,7 +1048,7 @@
       (pre-space is removed in dispatch_command)
 
       First '/' looks like comment before command it is not
-      frequently appeared in real lihe, consequently we can
+      frequently appeared in real life, consequently we can
       check all such queries, too.
     */
     if ((my_toupper(system_charset_info, sql[i])     != 'S' ||
@@ -1077,7 +1077,7 @@
   if (thd->db_length)
   {
     memcpy(sql+query_length+1, thd->db, thd->db_length);
-    DBUG_PRINT("qcache", ("database: '%s' length %u",
+    DBUG_PRINT("qcache", ("database: '%s'  length: %u",
 			  thd->db, thd->db_length));
   }
   else
@@ -1230,9 +1230,9 @@
       if (engine_data != table->engine_data())
       {
         DBUG_PRINT("qcache",
-                   ("Handler require invalidation queries of %s.%s %lld-%lld",
-                              table_list.db, table_list.alias,
-                              engine_data, table->engine_data()));
+                   ("Handler require invalidation queries of %s.%s %lu-%lu",
+                    table_list.db, table_list.alias,
+                    (ulong) engine_data, (ulong) table->engine_data()));
         invalidate_table((byte *) table->db(), table->key_length());
       }
       else
@@ -1253,10 +1253,10 @@
 #ifndef EMBEDDED_LIBRARY
   do
   {
-    DBUG_PRINT("qcache", ("Results  (len: %lu  used: %lu  headers: %u)",
+    DBUG_PRINT("qcache", ("Results  (len: %lu  used: %lu  headers: %lu)",
 			  result_block->length, result_block->used,
-			  result_block->headers_len()+
-			  ALIGN_SIZE(sizeof(Query_cache_result))));
+			  (ulong) (result_block->headers_len()+
+                                   ALIGN_SIZE(sizeof(Query_cache_result)))));
     
     Query_cache_result *result = result_block->result();
     if (net_real_write(&thd->net, result->data(),
@@ -1338,7 +1338,7 @@
       for (; tables_used; tables_used= tables_used->next)
       {
 	invalidate_table((byte*) tables_used->key, tables_used->key_length);
-	DBUG_PRINT("qcache", (" db %s, table %s", tables_used->key,
+	DBUG_PRINT("qcache", ("db: %s  table: %s", tables_used->key,
 			      tables_used->key+
 			      strlen(tables_used->key)+1));
       }
@@ -2349,7 +2349,7 @@
     {
       char key[MAX_DBKEY_LENGTH];
       uint key_length;
-      DBUG_PRINT("qcache", ("view %s, db %s",
+      DBUG_PRINT("qcache", ("view: %s  db: %s",
                             tables_used->view_name.str,
                             tables_used->view_db.str));
       key_length= (uint) (strmov(strmov(key, tables_used->view_db.str) + 1,
@@ -2470,11 +2470,11 @@
       table_block->table()->engine_data() != engine_data)
   {
     DBUG_PRINT("qcache",
-               ("Handler require invalidation queries of %s.%s %lld-%lld",
+               ("Handler require invalidation queries of %s.%s %lu-%lu",
                 table_block->table()->db(),
                 table_block->table()->table(),
-                engine_data,
-                table_block->table()->engine_data()));
+                (ulong) engine_data,
+                (ulong) table_block->table()->engine_data()));
     /*
       as far as we delete all queries with this table, table block will be
       deleted, too
@@ -2972,7 +2972,7 @@
     table_count++;
     if (tables_used->view)
     {
-      DBUG_PRINT("qcache", ("view %s, db %s",
+      DBUG_PRINT("qcache", ("view: %s  db: %s",
                             tables_used->view_name.str,
                             tables_used->view_db.str));
       *tables_type|= HA_CACHE_TBL_NONTRANSACT;
@@ -3038,7 +3038,7 @@
       lex->safe_to_cache_query)
   {
     DBUG_PRINT("qcache", ("options: %lx  %lx  type: %u",
-                          OPTION_TO_QUERY_CACHE,
+                          (long) OPTION_TO_QUERY_CACHE,
                           (long) lex->select_lex.options,
                           (int) thd->variables.query_cache_type));
 
@@ -3058,7 +3058,7 @@
   DBUG_PRINT("qcache",
 	     ("not interesting query: %d or not cacheable, options %lx %lx  type: %u",
 	      (int) lex->sql_command,
-	      OPTION_TO_QUERY_CACHE,
+	      (long) OPTION_TO_QUERY_CACHE,
 	      (long) lex->select_lex.options,
 	      (int) thd->variables.query_cache_type));
   DBUG_RETURN(0);
@@ -3757,8 +3757,8 @@
 	(((long)first_block) % (long)ALIGN_SIZE(1)))
     {
       DBUG_PRINT("error",
-		 ("block 0x%lx do not aligned by %d", (ulong) block,
-		  ALIGN_SIZE(1)));
+		 ("block 0x%lx do not aligned by %d", (long) block,
+		  (int) ALIGN_SIZE(1)));
       result = 1;
     }
     // Check memory allocation

--- 1.77/sql/ha_archive.cc	2006-11-30 18:24:53 +02:00
+++ 1.78/sql/ha_archive.cc	2006-11-30 21:48:30 +02:00
@@ -327,8 +327,8 @@
 
   DBUG_PRINT("ha_archive::read_meta_file", ("Check %d", (uint)meta_buffer[0]));
   DBUG_PRINT("ha_archive::read_meta_file", ("Version %d", (uint)meta_buffer[1]));
-  DBUG_PRINT("ha_archive::read_meta_file", ("Rows %lld", *rows));
-  DBUG_PRINT("ha_archive::read_meta_file", ("Checkpoint %lld", check_point));
+  DBUG_PRINT("ha_archive::read_meta_file", ("Rows %lu", (ulong) *rows));
+  DBUG_PRINT("ha_archive::read_meta_file", ("Checkpoint %lu", (ulong) check_point));
   DBUG_PRINT("ha_archive::read_meta_file", ("Dirty %d", (int)meta_buffer[18]));
 
   if ((meta_buffer[0] != (uchar)ARCHIVE_CHECK_HEADER) || 
@@ -359,8 +359,8 @@
   *(meta_buffer + 18)= (uchar)dirty;
   DBUG_PRINT("ha_archive::write_meta_file", ("Check %d", (uint)ARCHIVE_CHECK_HEADER));
   DBUG_PRINT("ha_archive::write_meta_file", ("Version %d", (uint)ARCHIVE_VERSION));
-  DBUG_PRINT("ha_archive::write_meta_file", ("Rows %llu", (ulonglong)rows));
-  DBUG_PRINT("ha_archive::write_meta_file", ("Checkpoint %llu", check_point));
+  DBUG_PRINT("ha_archive::write_meta_file", ("Rows %lu", (ulong)rows));
+  DBUG_PRINT("ha_archive::write_meta_file", ("Checkpoint %lu", (ulong) check_point));
   DBUG_PRINT("ha_archive::write_meta_file", ("Dirty %d", (uint)dirty));
 
   VOID(my_seek(meta_file, 0, MY_SEEK_SET, MYF(0)));
@@ -783,7 +783,7 @@
   if (scan)
   {
     scan_rows= share->rows_recorded;
-    DBUG_PRINT("info", ("archive will retrieve %llu rows", scan_rows));
+    DBUG_PRINT("info", ("archive will retrieve %lu rows", (ulong) scan_rows));
     records= 0;
 
     /* 
@@ -1019,7 +1019,8 @@
         share->rows_recorded++;
       }
     }
-    DBUG_PRINT("info", ("recovered %llu archive rows", share->rows_recorded));
+    DBUG_PRINT("info", ("recovered %lu archive rows",
+                        (ulong) share->rows_recorded));
 
     my_free((char*)buf, MYF(0));
     if (rc && rc != HA_ERR_END_OF_FILE)

--- 1.35/sql/tztime.cc	2006-11-20 22:41:56 +02:00
+++ 1.36/sql/tztime.cc	2006-11-30 21:48:30 +02:00
@@ -1729,9 +1729,9 @@
     tz_leapcnt++;
 
     DBUG_PRINT("info",
-      ("time_zone_leap_second table: tz_leapcnt=%u tt_time=%lld offset=%ld",
-       tz_leapcnt, (longlong)tz_lsis[tz_leapcnt-1].ls_trans,
-       tz_lsis[tz_leapcnt-1].ls_corr));
+               ("time_zone_leap_second table: tz_leapcnt: %u  tt_time: %lu  offset=%ld",
+                tz_leapcnt, (ulong) tz_lsis[tz_leapcnt-1].ls_trans,
+                tz_lsis[tz_leapcnt-1].ls_corr));
 
     res= table->file->index_next(table->record[0]);
   }
@@ -2041,8 +2041,8 @@
     tz_info->timecnt++;
 
     DBUG_PRINT("info",
-      ("time_zone_transition table: tz_id=%u tt_time=%lld tt_id=%u",
-       tzid, (longlong)ttime, ttid));
+               ("time_zone_transition table: tz_id: %u  tt_time: %lu  tt_id: %u",
+                tzid, (ulong) ttime, ttid));
 
     res= table->file->index_next_same(table->record[0],
                                       (byte*)table->field[0]->ptr, 4);

--- 1.65/ndb/src/mgmapi/mgmapi.cpp	2006-11-20 22:41:48 +02:00
+++ 1.66/ndb/src/mgmapi/mgmapi.cpp	2006-11-30 21:48:29 +02:00
@@ -178,7 +178,7 @@
   h->mgmd_version_minor= -1;
   h->mgmd_version_build= -1;
 
-  DBUG_PRINT("info", ("handle=0x%x", (UintPtr)h));
+  DBUG_PRINT("info", ("handle: 0x%lx", (long)h));
   DBUG_RETURN(h);
 }
 
@@ -195,7 +195,7 @@
 ndb_mgm_set_connectstring(NdbMgmHandle handle, const char * mgmsrv)
 {
   DBUG_ENTER("ndb_mgm_set_connectstring");
-  DBUG_PRINT("info", ("handle=0x%x", (UintPtr)handle));
+  DBUG_PRINT("info", ("handle: 0x%lx", (long)handle));
   handle->cfg.~LocalConfig();
   new (&(handle->cfg)) LocalConfig;
   if (!handle->cfg.init(mgmsrv, 0) ||
@@ -237,7 +237,7 @@
   DBUG_ENTER("ndb_mgm_destroy_handle");
   if(!handle)
     DBUG_VOID_RETURN;
-  DBUG_PRINT("info", ("handle=0x%x", (UintPtr)(* handle)));
+  DBUG_PRINT("info", ("handle: 0x%lx", (long)(* handle)));
   /**
    * important! only disconnect if connected
    * other code relies on this

--- 1.61/ndb/src/ndbapi/Ndb.cpp	2006-11-20 22:41:49 +02:00
+++ 1.62/ndb/src/ndbapi/Ndb.cpp	2006-11-30 21:48:29 +02:00
@@ -777,7 +777,7 @@
   }
   if (getTupleIdFromNdb(info, tupleId, cacheSize) == -1)
     DBUG_RETURN(-1);
-  DBUG_PRINT("info", ("value %llu", (ulonglong)tupleId));
+  DBUG_PRINT("info", ("value %lu", (ulong) tupleId));
   DBUG_RETURN(0);
 }
 
@@ -798,7 +798,7 @@
   }
   if (getTupleIdFromNdb(info, tupleId, cacheSize) == -1)
     DBUG_RETURN(-1);
-  DBUG_PRINT("info", ("value %llu", (ulonglong)tupleId));
+  DBUG_PRINT("info", ("value %lu", (ulong)tupleId));
   DBUG_RETURN(0);
 }
 
@@ -811,7 +811,7 @@
   {
     assert(info->m_first_tuple_id < info->m_last_tuple_id);
     tupleId = ++info->m_first_tuple_id;
-    DBUG_PRINT("info", ("next cached value %llu", (ulonglong)tupleId));
+    DBUG_PRINT("info", ("next cached value %lu", (ulong)tupleId));
   }
   else
   {
@@ -845,7 +845,7 @@
   }
   if (readTupleIdFromNdb(info, tupleId) == -1)
     DBUG_RETURN(-1);
-  DBUG_PRINT("info", ("value %llu", (ulonglong)tupleId));
+  DBUG_PRINT("info", ("value %lu", (ulong)tupleId));
   DBUG_RETURN(0);
 }
 
@@ -866,7 +866,7 @@
   }
   if (readTupleIdFromNdb(info, tupleId) == -1)
     DBUG_RETURN(-1);
-  DBUG_PRINT("info", ("value %llu", (ulonglong)tupleId));
+  DBUG_PRINT("info", ("value %lu", (ulong)tupleId));
   DBUG_RETURN(0);
 }
 
@@ -948,8 +948,8 @@
       {
 	info->m_first_tuple_id = tupleId - 1;
         DBUG_PRINT("info", 
-                   ("Setting next auto increment cached value to %llu",
-                    (ulonglong)tupleId));  
+                   ("Setting next auto increment cached value to %lu",
+                    (ulong)tupleId));  
 	DBUG_RETURN(0);
       }
     }
@@ -976,7 +976,8 @@
 {
   DBUG_ENTER("Ndb::opTupleIdOnNdb");
   Uint32 aTableId = info->m_table_impl->m_tableId;
-  DBUG_PRINT("enter", ("table=%u value=%llu op=%u", aTableId, opValue, op));
+  DBUG_PRINT("enter", ("table: %u  value: %lu  op: %u",
+                       aTableId, (ulong) opValue, op));
 
   NdbTransaction*     tConnection;
   NdbOperation*      tOperation= 0; // Compiler warning if not initialized
@@ -1050,8 +1051,8 @@
       else
       {
         DBUG_PRINT("info", 
-                   ("Setting next auto increment value (db) to %llu",
-                    (ulonglong)opValue));  
+                   ("Setting next auto increment value (db) to %lu",
+                    (ulong)opValue));  
         info->m_first_tuple_id = info->m_last_tuple_id = opValue - 1;
       }
       break;
@@ -1247,7 +1248,7 @@
   if (!table)
   {
     DBUG_PRINT("error", ("!table"));
-    return ret;
+    DBUG_RETURN(ret);
   }
 
   if (fullyQualifiedNames)

--- 1.53/ndb/src/ndbapi/NdbTransaction.cpp	2006-11-20 22:41:49 +02:00
+++ 1.54/ndb/src/ndbapi/NdbTransaction.cpp	2006-11-30 21:48:30 +02:00
@@ -1007,7 +1007,8 @@
 NdbTransaction::releaseExecutedScanOperation(NdbIndexScanOperation* cursorOp)
 {
   DBUG_ENTER("NdbTransaction::releaseExecutedScanOperation");
-  DBUG_PRINT("enter", ("this=0x%x op=0x%x", (UintPtr)this, (UintPtr)cursorOp));
+  DBUG_PRINT("enter", ("this: 0x%lx  op=0x%lx",
+                       (long)this, (long)cursorOp));
   
   releaseScanOperation(&m_firstExecutedScanOp, 0, cursorOp);
   

--- 1.79/ndb/src/ndbapi/NdbScanOperation.cpp	2006-10-12 19:55:50 +03:00
+++ 1.80/ndb/src/ndbapi/NdbScanOperation.cpp	2006-11-30 21:48:30 +02:00
@@ -653,9 +653,9 @@
 void NdbScanOperation::close(bool forceSend, bool releaseOp)
 {
   DBUG_ENTER("NdbScanOperation::close");
-  DBUG_PRINT("enter", ("this=%x tcon=%x con=%x force=%d release=%d",
-                       (UintPtr)this,
-                       (UintPtr)m_transConnection, (UintPtr)theNdbCon,
+  DBUG_PRINT("enter", ("this: 0x%lx  tcon: 0x%lx  con: 0x%lx  force: %d  release: %d",
+                       (long)this,
+                       (long)m_transConnection, (long)theNdbCon,
                        forceSend, releaseOp));
 
   if(m_transConnection){

--- 1.17/ndb/src/ndbapi/Ndblist.cpp	2005-09-20 13:07:15 +03:00
+++ 1.18/ndb/src/ndbapi/Ndblist.cpp	2006-11-30 21:48:30 +02:00
@@ -361,7 +361,7 @@
 Ndb::releaseScanOperation(NdbIndexScanOperation* aScanOperation)
 {
   DBUG_ENTER("Ndb::releaseScanOperation");
-  DBUG_PRINT("enter", ("op=%x", (UintPtr)aScanOperation));
+  DBUG_PRINT("enter", ("op: 0x%lx", (long)aScanOperation));
 #ifdef ndb_release_check_dup
   { NdbIndexScanOperation* tOp = theScanOpIdleList;
     while (tOp != NULL) {

--- 1.287/sql/ha_ndbcluster.cc	2006-11-20 22:41:52 +02:00
+++ 1.288/sql/ha_ndbcluster.cc	2006-11-30 21:48:30 +02:00
@@ -822,8 +822,8 @@
         {
           char *buf= m_blobs_buffer + offset;
           uint32 len= 0xffffffff;  // Max uint32
-          DBUG_PRINT("value", ("read blob ptr=%x len=%u",
-                               (UintPtr)buf, (uint)blob_len));
+          DBUG_PRINT("value", ("read blob ptr: 0x%lx  len: %u",
+                               (long)buf, (uint)blob_len));
           if (ndb_blob->readData(buf, len) != 0)
             DBUG_RETURN(-1);
           DBUG_ASSERT(len == blob_len);

--- 1.116/innobase/os/os0file.c	2006-08-18 15:16:05 +03:00
+++ 1.117/innobase/os/os0file.c	2006-11-30 21:48:29 +02:00
@@ -1718,7 +1718,7 @@
 	        }
 				
 		/* Print about progress for each 100 MB written */
-		if ((current_size + n_bytes) / (ib_longlong)(100 * 1024 * 1024)
+		if ((ib_longlong) (current_size + n_bytes) / (ib_longlong)(100 * 1024 * 1024)
 		    != current_size / (ib_longlong)(100 * 1024 * 1024)) {
 
 		        fprintf(stderr, " %lu00",

--- 1.26/sql/uniques.cc	2006-11-30 18:25:02 +02:00
+++ 1.27/sql/uniques.cc	2006-11-30 21:48:30 +02:00
@@ -428,8 +428,8 @@
   BUFFPEK_COMPARE_CONTEXT compare_context = { compare, compare_arg };
   QUEUE queue;
   if (end <= begin ||
-      merge_buffer_size < key_length * (end - begin + 1) ||
-      init_queue(&queue, end - begin, offsetof(BUFFPEK, key), 0,
+      merge_buffer_size < (ulong) (key_length * (end - begin + 1)) ||
+      init_queue(&queue, (uint) (end - begin), offsetof(BUFFPEK, key), 0,
                  buffpek_compare, &compare_context))
     return 1;
   /* we need space for one key when a piece of merge buffer is re-read */

--- 1.259/client/mysqltest.c	2006-11-17 08:24:38 +02:00
+++ 1.260/client/mysqltest.c	2006-11-30 21:48:29 +02:00
@@ -946,8 +946,8 @@
     die(NullS);
   if (!eval_result && (uint) stat_info.st_size != ds->length)
   {
-    DBUG_PRINT("info",("Size differs:  result size: %u  file size: %llu",
-		       ds->length, stat_info.st_size));
+    DBUG_PRINT("info",("Size differs:  result size: %u  file size: %lu",
+		       ds->length, (ulong) stat_info.st_size));
     DBUG_PRINT("info",("result: '%s'", ds->str));
     DBUG_RETURN(RESULT_LENGTH_MISMATCH);
   }
@@ -3130,14 +3130,15 @@
     else if (!strncmp(con_options, "COMPRESS", 8))
       con_compress= 1;
     else
-      die("Illegal option to connect: %.*s", end - con_options, con_options);
+      die("Illegal option to connect: %.*s", 
+          (int) (end - con_options), con_options);
     /* Process next option */
     con_options= end;
   }
 
   if (next_con == connections_end)
     die("Connection limit exhausted, you can have max %d connections",
-        (sizeof(connections)/sizeof(struct st_connection)));
+        (int) (sizeof(connections)/sizeof(struct st_connection)));
 
   if (find_connection_by_name(ds_connection_name.str))
     die("Connection %s already exists", ds_connection_name.str);
@@ -3458,10 +3459,10 @@
 	DBUG_RETURN(0);
       }
       else if ((c == '{' &&
-                (!my_strnncoll_simple(charset_info, "while", 5,
-                                      buf, min(5, p - buf), 0) ||
-                 !my_strnncoll_simple(charset_info, "if", 2,
-                                      buf, min(2, p - buf), 0))))
+                (!my_strnncoll_simple(charset_info, (const uchar*) "while", 5,
+                                      (uchar*) buf, min(5, p - buf), 0) ||
+                 !my_strnncoll_simple(charset_info, (const uchar*) "if", 2,
+                                      (uchar*) buf, min(2, p - buf), 0))))
       {
         /* Only if and while commands can be terminated by { */
         *p++= c;

--- 1.17/myisammrg/myrg_rkey.c	2005-09-23 11:48:56 +03:00
+++ 1.18/myisammrg/myrg_rkey.c	2006-11-30 21:48:29 +02:00
@@ -88,7 +88,7 @@
   mi=(info->current_table=(MYRG_TABLE *)queue_top(&(info->by_key)))->table;
   mi->once_flags|= RRND_PRESERVE_LASTINX;
   DBUG_PRINT("info", ("using table no: %d",
-                      info->current_table - info->open_tables + 1));
+                      (int) (info->current_table - info->open_tables + 1)));
   DBUG_DUMP("result key", (byte*) mi->lastkey, mi->lastkey_length);
   DBUG_RETURN(_myrg_mi_read_record(mi,buf));
 }

--- 1.4/extra/yassl/taocrypt/include/algebra.hpp	2006-07-12 22:15:02 +03:00
+++ 1.5/extra/yassl/taocrypt/include/algebra.hpp	2006-11-30 21:48:29 +02:00
@@ -75,7 +75,7 @@
     typedef Integer Element;
 
     AbstractRing() : AbstractGroup() {m_mg.m_pRing = this;}
-    AbstractRing(const AbstractRing &source) {m_mg.m_pRing = this;}
+    AbstractRing(const AbstractRing &source) :AbstractGroup() {m_mg.m_pRing = this;}
     AbstractRing& operator=(const AbstractRing &source) {return *this;}
 
     virtual bool IsUnit(const Element &a) const =0;
Thread
bk commit into 5.0 tree (monty:1.2328)monty30 Nov